Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The error message is not user-friendly when adding duplicate permissi… #12805

Merged
merged 6 commits into from
Dec 5, 2024

Conversation

zhouchunhai
Copy link
Contributor

@zhouchunhai zhouchunhai commented Oct 31, 2024

…ons. (#12773)

What is the purpose of the change

The error message is not user-friendly when adding duplicate permissions.

Copy link

Thanks for your this PR. 🙏
Please check again for your PR changes whether contains any usage/api/configuration change such as Add new API , Add new configuration, Change default value of configuration.
If so, please add or update documents(markdown type) in docs/next/ for repository nacos-group/nacos-group.github.io


感谢您提交的PR。 🙏
请再次查看您的PR内容,确认是否包含任何使用方式/API/配置参数的变更,如:新增API新增配置参数修改默认配置等操作。
如果是,请确保在提交之前,在仓库nacos-group/nacos-group.github.io中的docs/next/目录下添加或更新文档(markdown格式)。

@codecov-commenter
Copy link

codecov-commenter commented Oct 31, 2024

Codecov Report

Attention: Patch coverage is 36.36364% with 7 lines in your changes missing coverage. Please review.

Project coverage is 72.26%. Comparing base (2a0dafa) to head (b99ca34).
Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
...s/plugin/auth/impl/roles/NacosRoleServiceImpl.java 30.00% 3 Missing and 4 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #12805      +/-   ##
=============================================
+ Coverage      72.25%   72.26%   +0.01%     
- Complexity      9826     9834       +8     
=============================================
  Files           1287     1287              
  Lines          41445    41456      +11     
  Branches        4373     4377       +4     
=============================================
+ Hits           29947    29960      +13     
+ Misses          9396     9391       -5     
- Partials        2102     2105       +3     
Files with missing lines Coverage Δ
...gin/auth/impl/controller/PermissionController.java 100.00% <100.00%> (ø)
...s/plugin/auth/impl/roles/NacosRoleServiceImpl.java 27.70% <30.00%> (+0.16%) ⬆️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a0dafa...b99ca34. Read the comment docs.

@wuyfee
Copy link

wuyfee commented Oct 31, 2024

$\color{green}{SUCCESS}$
DETAILS
✅ - docker: success
✅ - deploy (standalone & cluster & standalone_auth): success
✅ - e2e-java-test (standalone & cluster & standalone_auth): success
✅ - e2e-go-test (standalone & cluster): success
✅ - e2e-cpp-test (standalone & cluster): success
✅ - e2e-csharp-test (standalone & cluster): success
✅ - e2e-nodejs-test (standalone & cluster): success
✅ - e2e-python-test (standalone & cluster): success
✅ - clean (standalone & cluster & standalone_auth): success

@KomachiSion
Copy link
Collaborator

Is relatived with #12803?

@zhouchunhai
Copy link
Contributor Author

It's relatived with #12773

@KomachiSion
Copy link
Collaborator

But I think add these two http api can't solve this problem.

the console ui will not call these two api.

@zhouchunhai
Copy link
Contributor Author

My colleague has already submitted a Pull Request (PR). The console ui will call the new API to check if the permission already exists.

@KomachiSion
Copy link
Collaborator

My colleague has already submitted a Pull Request (PR). The console ui will call the new API to check if the permission already exists.

So I ask you whether your pr is relative with #12803 ?

@zhouchunhai
Copy link
Contributor Author

yes, it's relative with #12803

@KomachiSion KomachiSion added the area/Nacos console Related to Nacos consle label Nov 12, 2024
@KomachiSion KomachiSion added this to the 2.5.0 milestone Nov 12, 2024
@wuyfee
Copy link

wuyfee commented Nov 21, 2024

$\color{red}{FAILURE}$
DETAILS
✅ - docker: success
✅ - deploy (standalone & cluster & standalone_auth): success
✅ - e2e-java-test (standalone & cluster & standalone_auth): success
✅ - e2e-go-test (standalone & cluster): success
✅ - e2e-cpp-test (standalone & cluster): success
❌ - e2e-csharp-test (standalone & cluster): failure
✅ - e2e-nodejs-test (standalone & cluster): success
✅ - e2e-python-test (standalone & cluster): success
✅ - clean (standalone & cluster & standalone_auth): success

@wuyfee
Copy link

wuyfee commented Nov 21, 2024

$\color{red}{FAILURE}$
DETAILS
✅ - docker: success
✅ - deploy (standalone & cluster & standalone_auth): success
✅ - e2e-java-test (standalone & cluster & standalone_auth): success
✅ - e2e-go-test (standalone & cluster): success
✅ - e2e-cpp-test (standalone & cluster): success
❌ - e2e-csharp-test (standalone & cluster): failure
✅ - e2e-nodejs-test (standalone & cluster): success
✅ - e2e-python-test (standalone & cluster): success
✅ - clean (standalone & cluster & standalone_auth): success

@wuyfee
Copy link

wuyfee commented Nov 29, 2024

$\color{green}{SUCCESS}$
DETAILS
✅ - docker: success
✅ - deploy (standalone & cluster & standalone_auth): success
✅ - e2e-java-test (standalone & cluster & standalone_auth): success
✅ - e2e-go-test (standalone & cluster): success
✅ - e2e-cpp-test (standalone & cluster): success
✅ - e2e-csharp-test (standalone & cluster): success
✅ - e2e-nodejs-test (standalone & cluster): success
✅ - e2e-python-test (standalone & cluster): success
✅ - clean (standalone & cluster & standalone_auth): success

@KomachiSion
Copy link
Collaborator

Hello, you new code ci can't pass, please check the detail log and fix it.

@wuyfee
Copy link

wuyfee commented Dec 4, 2024

$\color{green}{SUCCESS}$
DETAILS
✅ - docker: success
✅ - deploy (standalone & cluster & standalone_auth): success
✅ - e2e-java-test (standalone & cluster & standalone_auth): success
✅ - e2e-go-test (standalone & cluster): success
✅ - e2e-cpp-test (standalone & cluster): success
✅ - e2e-csharp-test (standalone & cluster): success
✅ - e2e-nodejs-test (standalone & cluster): success
✅ - e2e-python-test (standalone & cluster): success
✅ - clean (standalone & cluster & standalone_auth): success

@DirtyBit64
Copy link
Contributor

角色管理模块添加重复的绑定关系(角色-用户)也存在同样的问题

@KomachiSion KomachiSion merged commit 66705e3 into alibaba:develop Dec 5, 2024
7 checks passed
@KomachiSion
Copy link
Collaborator

角色管理模块添加重复的绑定关系(角色-用户)也存在同样的问题

Welcome to contribute.

@DirtyBit64
Copy link
Contributor

角色管理模块添加重复的绑定关系(角色-用户)也存在同样的问题

Welcome to contribute.

好的,已提交PR #12926

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/Nacos console Related to Nacos consle
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants