-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The error message is not user-friendly when adding duplicate permissi… #12805
Conversation
Thanks for your this PR. 🙏 感谢您提交的PR。 🙏 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #12805 +/- ##
=============================================
+ Coverage 72.25% 72.26% +0.01%
- Complexity 9826 9834 +8
=============================================
Files 1287 1287
Lines 41445 41456 +11
Branches 4373 4377 +4
=============================================
+ Hits 29947 29960 +13
+ Misses 9396 9391 -5
- Partials 2102 2105 +3
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
|
Is relatived with #12803? |
It's relatived with #12773 |
But I think add these two http api can't solve this problem. the console ui will not call these two api. |
My colleague has already submitted a Pull Request (PR). The console ui will call the new API to check if the permission already exists. |
So I ask you whether your pr is relative with #12803 ? |
yes, it's relative with #12803 |
...plugin/src/main/java/com/alibaba/nacos/plugin/auth/impl/controller/PermissionController.java
Outdated
Show resolved
Hide resolved
|
...plugin/src/main/java/com/alibaba/nacos/plugin/auth/impl/controller/PermissionController.java
Outdated
Show resolved
Hide resolved
|
|
Hello, you new code ci can't pass, please check the detail log and fix it. |
|
角色管理模块添加重复的绑定关系(角色-用户)也存在同样的问题 |
Welcome to contribute. |
好的,已提交PR #12926 |
…ons. (#12773)
What is the purpose of the change
The error message is not user-friendly when adding duplicate permissions.