Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The error message is not user-friendly when adding duplicate permissions. #12773

Closed
zhouchunhai opened this issue Oct 22, 2024 · 2 comments
Closed

The error message is not user-friendly when adding duplicate permissions. #12773

zhouchunhai opened this issue Oct 22, 2024 · 2 comments
Labels
area/Nacos console Related to Nacos consle contribution welcome
Milestone
2.5.0

Comments

@zhouchunhai
Copy link
Contributor

Describe the bug
The error message is not user-friendly when adding duplicate permissions.

Expected behavior
I expect a friendly error message, such as 'This permission already exists, please do not add it again.'

Actually behavior
The prompt is not friendly enough, as it prints out backend stack trace information.

How to Reproduce
Steps to reproduce the behavior:

  1. Enter the permission management page.
  2. Add a permission.
  3. Add the same permission again.
  4. See errors

Desktop (please complete the following information):

  • OS: [Windows]
  • Version [nacos-server 2.4.1]
  • Module [config]
  • SDK [spring-cloud-alibaba-nacos]

Additional context
image
@zhouchunhai zhouchunhai reopened this Oct 22, 2024
@KomachiSion
Copy link
Collaborator

Can you upgrade to new version and retry?

@zhouchunhai
Copy link
Contributor Author

version 2.4.3 still has this problem.
image

littlesparklet added a commit to littlesparklet/nacos that referenced this issue Oct 31, 2024
@littlesparklet
The error message is not user-friendly when adding duplicate permissi…
99e3eaf 
…ons. (alibaba#12773)
@littlesparklet littlesparklet mentioned this issue Oct 31, 2024
Merged
@zhouchunhai zhouchunhai mentioned this issue Nov 1, 2024
Merged
@DirtyBit64 DirtyBit64 mentioned this issue Nov 24, 2024
Closed
3 tasks
littlesparklet added a commit to littlesparklet/nacos that referenced this issue Nov 29, 2024
@littlesparklet
The error message is not user-friendly when adding duplicate permissi…
568707c 
…ons.(alibaba#12773)
zhouchunhai added a commit to zhouchunhai/nacos that referenced this issue Nov 29, 2024
@zhouchunhai
The error message is not user-friendly when adding duplicate permissi…
8525a6b 
…ons. (alibaba#12773)
This was referenced Dec 4, 2024
Closed
Closed
KomachiSion pushed a commit that referenced this issue Dec 5, 2024
@zhouchunhai
The error message is not user-friendly when adding duplicate permissi… (
66705e3 
#12805)

* The error message is not user-friendly when adding duplicate permissions. (#12273)

* The error message is not user-friendly when adding duplicate permissions. (#12773)

* add some unit test.

* fix ci fail.
KomachiSion pushed a commit that referenced this issue Dec 5, 2024
@littlesparklet
The error message is not user-friendly when adding duplicate permissi… (
4961191 
#12803)

* The error message is not user-friendly when adding duplicate permissions. (#12773)

* The error message is not user-friendly when adding duplicate permissions.(#12773)
@KomachiSion KomachiSion added this to the 2.5.0 milestone Dec 5, 2024
@DirtyBit64 DirtyBit64 mentioned this issue Dec 5, 2024
Merged
5 tasks
KomachiSion pushed a commit that referenced this issue Dec 6, 2024
@DirtyBit64
[ISSUE #12773] Fix unfriendly message when adding duplicate permissio…
d4f5421 
…ns or binding relationship. (#12926)

* Fix unfriendly message when adding duplicate roles.

* unit test.

* correct code style.

* correct code style.

* correct code style.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/Nacos console Related to Nacos consle contribution welcome
Projects
None yet
Milestone
2.5.0
Development

No branches or pull requests
2 participants
@KomachiSion @zhouchunhai