Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #12773] Fix unfriendly message when adding duplicate permissions or binding relationship. #12917

Closed
wants to merge 0 commits into from

Conversation

DirtyBit64
Copy link
Contributor

What is the purpose of the change

Resolve the same issues in role management and permission management in the console : #12773.

Brief changelog

Modified com.alibaba.nacos.plugin.auth.impl.roles.NacosRoleServiceImpl.addXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

Copy link

github-actions bot commented Dec 4, 2024

Thanks for your this PR. 🙏
Please check again for your PR changes whether contains any usage/api/configuration change such as Add new API , Add new configuration, Change default value of configuration.
If so, please add or update documents(markdown type) in docs/next/ for repository nacos-group/nacos-group.github.io


感谢您提交的PR。 🙏
请再次查看您的PR内容,确认是否包含任何使用方式/API/配置参数的变更,如:新增API新增配置参数修改默认配置等操作。
如果是,请确保在提交之前,在仓库nacos-group/nacos-group.github.io中的docs/next/目录下添加或更新文档(markdown格式)。

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 19 lines in your changes missing coverage. Please review.

Project coverage is 72.23%. Comparing base (0de3352) to head (b0a20c4).

Files with missing lines Patch % Lines
...s/plugin/auth/impl/roles/NacosRoleServiceImpl.java 0.00% 19 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #12917      +/-   ##
=============================================
- Coverage      72.26%   72.23%   -0.03%     
- Complexity      9827     9828       +1     
=============================================
  Files           1287     1287              
  Lines          41445    41464      +19     
  Branches        4373     4383      +10     
=============================================
+ Hits           29949    29951       +2     
- Misses          9395     9413      +18     
+ Partials        2101     2100       -1     
Files with missing lines Coverage Δ
...s/plugin/auth/impl/roles/NacosRoleServiceImpl.java 24.20% <0.00%> (-3.34%) ⬇️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0de3352...b0a20c4. Read the comment docs.

@KomachiSion
Copy link
Collaborator

Can you add some unit test for this changes?

@DirtyBit64
Copy link
Contributor Author

Can you add some unit test for this changes?

Sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants