Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Echo Metrics Test #293

Merged
merged 3 commits into from
Jan 20, 2025
Merged

Add Echo Metrics Test #293

merged 3 commits into from
Jan 20, 2025

Conversation

martinyonatann
Copy link
Contributor

No description provided.

@martinyonatann martinyonatann changed the title enhance Echo rule with Metrics Support [WIP] enhance Echo rule with Metrics Support Jan 19, 2025
@martinyonatann martinyonatann force-pushed the feature/echo-metrics branch 2 times, most recently from d8f0f4e to 3433eb8 Compare January 19, 2025 10:30
@martinyonatann martinyonatann changed the title [WIP] enhance Echo rule with Metrics Support enhance Echo rule with Metrics Support Jan 19, 2025
@martinyonatann
Copy link
Contributor Author

please help to review this PR @123liuziming

123liuziming
123liuziming reviewed Jan 20, 2025
View reviewed changes
Copy link
Collaborator

@123liuziming 123liuziming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

echo uses net/http as the underlying communication framework, so this plugin doesn't need to generate metric or trace. You can only add a test to verify metric generated by net/http, thanks!

@martinyonatann
Copy link
Contributor Author

echo uses net/http as the underlying communication framework, so this plugin doesn't need to generate metric or trace. You can only add a test to verify metric generated by net/http, thanks!

Got it! Thanks for sharing this knowledge, @123liuziming. I'll make the changes accordingly. Much appreciated!

@martinyonatann martinyonatann changed the title enhance Echo rule with Metrics Support Add Echo Metrics Test Jan 20, 2025
123liuziming
123liuziming approved these changes Jan 20, 2025
View reviewed changes
Copy link
Collaborator

@123liuziming 123liuziming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Terrific job! Thanks!

@123liuziming 123liuziming merged commit 4fe3027 into alibaba:main Jan 20, 2025
9 checks passed
minimAluminiumalism pushed a commit to minimAluminiumalism/opentelemetry-go-auto-instrumentation that referenced this pull request Feb 20, 2025
@martinyonatann
Add Echo Metrics Test (alibaba#293)
efe25ab 
* echo metrics test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@123liuziming 123liuziming 123liuziming approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martinyonatann @123liuziming