DCP error management #1328
Merged
DCP error management #1328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Throw an error instead of a warning when trying to load a non existing DCP profile. rawColorInterpretation: In cameraInit, automatically switch to librawWhiteBalancing mode when a DCP profile is required but no error is requested if it is missing and no database or an erroneous one is given as parameter or if the expected profile does not exist in the database. Add working color space as a parameter in sampling and merging HDR exec.
fabiencastan
requested changes
Jan 7, 2023
fabiencastan
approved these changes
Jan 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Throw an error instead of a warning when trying to load a non existing DCP profile.
cameraInit: rawColorInterpretation automatically switch to librawWhiteBalancing mode and throw a warning when a DCP profile is required but no error is requested if it is missing and no database or an erroneous one is given as parameter or if the expected profile does not exist in the database.
Add working color space as a parameter in sampling and merging HDR exec.
Features list
Implementation remarks