Use DCP by default if the database is set and create errors on missing DCP files #1863
+57
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add working color space as input parameter in Sampling, Calibration and Merging HDR nodes. (unused in calibration, but useful to transfer from sampling to merging in pipelines) Update rawColorInterpretation default value and add some comments in cameraInit.
fabiencastan
changed the title
fabiencastan
approved these changes
Jan 14, 2023
fabiencastan
added a commit
that referenced
this pull request
Jan 22, 2023
The PR #1863 changes the order of parameters and modify the node UID, so it requires a version upgrade.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update rawColorInterpretation default value and add some comments in cameraInit node.
Add working color space as input parameter in Sampling, Calibration and Merging HDR nodes.
Update HDR pipelines accordingly.
Based on alicevision/AliceVision#1328