Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UVAtlas: downscale charts to fit in texture #598

Merged
merged 2 commits into from
Feb 28, 2019

Conversation

yann-lty
Copy link
Member

Description

Fix infinite loop when charts are larger than final texture size.
Fix #395

Features list

  • downscale charts to fit in texture
  • add sanity checks to avoid infinite loop and detect wrong configurations

Implementation remarks

Apply downscale factor to fit larger charts into the texture, and use it when filling atlases and computing final UV textures.

avoid infinite loop trying to build atlases
* ensure charts can't be larger than texture size (taking padding into account) by downscaling them
* use downscaled charts to fill atlases
* apply downscale factor when computing final UV coordinates
@fabiencastan fabiencastan merged commit 12a02dd into develop Feb 28, 2019
@fabiencastan fabiencastan deleted the dev_texturing_fitAtlas branch February 28, 2019 14:52
@fabiencastan fabiencastan added this to the 2019.X milestone Mar 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants