Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[request] Integrate AprilTag library for detection of markers (tag16h5 family) #1179

Closed
elektrokokke opened this issue Dec 11, 2020 · 1 comment · Fixed by #1180
Closed
Labels
feature request feature request from the community

Comments

@elektrokokke
Copy link
Contributor

Corresponding Meshroom issue for AliceVision feature issue 949.

In the modules where it makes sense, add "tag16h5" to the available describer types, enabling the usage of AprilTag markers from the tag16h5 family.

@elektrokokke elektrokokke added the feature request feature request from the community label Dec 11, 2020
elektrokokke pushed a commit to elektrokokke/meshroom that referenced this issue Dec 11, 2020
add the describer type "tag16h5" to the following modules:
- ConvertSfmFormat (e.g., to be able to export the 3D AprilTag positions in a human-readable format as .sfm,
or to see only the AprilTag marker positions in the 3D view via .abc)
- FeatureExtraction (to be able to detect AprilTag markers from the tag16h5 family)
- FeatureMatching (to be able to match AprilTag markers)
- SfmTransform (to be able to use AprilTag markers, e.g., for the auto_from_markers transform)
- StructureFromMotion (to be able to compute the 3D positions of AprilTag markers)
@natowi
Copy link
Member

natowi commented Dec 11, 2020

You don´t need to open an issue if you already opened a pull request

fabiencastan added a commit that referenced this issue Jul 23, 2021
…ion pull request #950 (#1180)

* According to Meshroom issue #1179 (#1179),
add the describer type "tag16h5" to the following modules:
- ConvertSfmFormat (e.g., to be able to export the 3D AprilTag positions in a human-readable format as .sfm,
or to see only the AprilTag marker positions in the 3D view via .abc)
- FeatureExtraction (to be able to detect AprilTag markers from the tag16h5 family)
- FeatureMatching (to be able to match AprilTag markers)
- SfmTransform (to be able to use AprilTag markers, e.g., for the auto_from_markers transform)
- StructureFromMotion (to be able to compute the 3D positions of AprilTag markers)

* Added a new input to sfmTransform: markerDistances, which is a pair of marker IDs associated with the distance between them.
Added a corresponding new transform: from_marker_distances, which scales the model according to the given distances between pairs of markers.
Added another transform: auto_from_markers, which uses the existing markers parameter (ignoring their x,y,z positions) and applies the auto_from_... function only based on these given markers. The latter transform can, e.g., be used to align a set of markers with the ground plane.

* Revert "Added a new input to sfmTransform: markerDistances, which is a pair of marker IDs associated with the distance between them."

This reverts commit ed87c68.

Co-authored-by: jarne <jarne@ieee.org>
Co-authored-by: Fabien Castan <fabcastan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request feature request from the community
Projects
None yet
2 participants