Integration of AprilTag library according to issue #1179 and AliceVision pull request #950 #1180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add the describer type "tag16h5" to the following modules: - ConvertSfmFormat (e.g., to be able to export the 3D AprilTag positions in a human-readable format as .sfm, or to see only the AprilTag marker positions in the 3D view via .abc) - FeatureExtraction (to be able to detect AprilTag markers from the tag16h5 family) - FeatureMatching (to be able to match AprilTag markers) - SfmTransform (to be able to use AprilTag markers, e.g., for the auto_from_markers transform) - StructureFromMotion (to be able to compute the 3D positions of AprilTag markers)
…f marker IDs associated with the distance between them. Added a corresponding new transform: from_marker_distances, which scales the model according to the given distances between pairs of markers. Added another transform: auto_from_markers, which uses the existing markers parameter (ignoring their x,y,z positions) and applies the auto_from_... function only based on these given markers. The latter transform can, e.g., be used to align a set of markers with the ground plane.
|
Ouch, sorry, just pushed another commit to the fork which was meant for a different branch, not realizing that this would go into this pull request. |
…a pair of marker IDs associated with the distance between them." This reverts commit ed87c68.
simogasp
added
the
do not close
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to Meshroom issue #1179 (#1179),
add the describer type "tag16h5" to the following modules:
or to see only the AprilTag marker positions in the 3D view via .abc)
This goes together with the AliceVision pull request 950 (alicevision/AliceVision#950).
Description
Features list
Implementation remarks