[ui] Paste nodes at the center of the Graph Editor when it does not contain the mouse #1788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we not just check if the mouse position is in the GraphEditor? If it's not inside, the paste is done at the center. |
…mouse When using the Edit > Paste menu, or when pressing Ctrl+V while the Graph Editor has the focus but the mouse is not contained in it, there is no current mouse position in the GraphEditor so the position that is provided to the "pasteNodes" function is the last known mouse position, which is oftentimes on the border of the GraphEditor. This commit automatically sets the mouse's position to the center of the GraphEditor, and "builds" the zone containing the pasted nodes around it.
cbentejac
force-pushed
the
dev/centerCopyPasteNodes
branch
from
09a63f8 to
021770a
Compare
You're right: that way, we can also paste nodes at the center when the Graph Editor still has the focus but does not contain the mouse. |
cbentejac
changed the title
fabiencastan
approved these changes
Oct 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using the Edit > Paste action menu, or when pressing Ctrl+V while the Graph Editor has the focus but does not contain the mouse, there is no current mouse position within the GraphEditor. The position that is provided to the "pasteNodes" function is the last known mouse position within the Graph Editor, which oftentimes corresponds to its borders.
Instead of using the border of the Graph Editor as the top-left corner of the pasting zone (the zone in which all the nodes contained in the clipboard will be pasted, with their original distance to one another preserved), this PR simulates the mouse's position and sets it at the center of the Graph Editor. This position is then used as the center of the pasting zone instead of its top-left corner. Distances between the pasted nodes remain unchanged.