Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nodes] new SfMTriangulation node #1842

Merged
merged 6 commits into from
Jan 14, 2023
Merged

Conversation

mh0g
Copy link
Contributor

@mh0g mh0g commented Dec 8, 2022

Description

Adds a main that is essentially the triangulation step from the sequential SfM.
AliceVision PR: alicevision/AliceVision#1314

Features list

This allows to run the triangulation without going into the sfm step.

@mh0g mh0g marked this pull request as draft December 8, 2022 15:35
@mh0g mh0g self-assigned this Dec 19, 2022
@mh0g mh0g requested a review from mugulmd December 19, 2022 14:23
@mugulmd
Copy link
Contributor

mugulmd commented Dec 20, 2022

When testing this node it kept failing with the following error:
ERROR: unrecognised option '--maxMemory=9223372036854771712'

@mh0g mh0g marked this pull request as ready for review December 21, 2022 14:06
@mh0g mh0g force-pushed the dev/triangulate_only branch from 2403666 to 57269c8 Compare December 21, 2022 14:38
@mugulmd
Copy link
Contributor

mugulmd commented Dec 22, 2022

Tested on 3 datasets by using the output of the StructureFromMotion node as input of the Triangulate node.
Results:

  • the generated landmarks are similar to the ones generated by StructureFromMotion, with a few differences (which is expected since there is no bundle adjustment)
  • when increasing the minNumberOfObservationsForTriangulation the number of landmarks decreases (which is expected).

I also ran the following sanity check: when using an SfMData without poses as input, no landmark is generated.

@mugulmd mugulmd changed the title started node triangulate based on sfm node [nodes] new Triangulate node Dec 22, 2022
@mh0g mh0g force-pushed the dev/triangulate_only branch from 57269c8 to 0abd8f6 Compare December 22, 2022 15:51
@mh0g
Copy link
Contributor Author

mh0g commented Dec 22, 2022

Tested on 3 datasets by using the output of the StructureFromMotion node as input of the Triangulate node. Results:

* the generated landmarks are similar to the ones generated by `StructureFromMotion`, with a few differences (which is expected since there is no bundle adjustment)

* when increasing the `minNumberOfObservationsForTriangulation` the number of landmarks decreases (which is expected).

I also ran the following sanity check: when using an SfMData without poses as input, no landmark is generated.

Tested on windows, seems to work as intended.
Tested on a benchmark dataset with ground truth poses and features/matches from meshroom. Small differences vs running with poses from SfM (as expected). Can also confirm that the landmarks are recomputed when using the ouptut of the Sfm node.

@fabiencastan
Copy link
Member

It would be good to also add a node for https://github.com/alicevision/AliceVision/blob/develop/src/software/pipeline/main_computeStructureFromKnownPoses.cpp
Or fuse them in a single node.

@fabiencastan
Copy link
Member

After checking, no need to integrate computeStructureFromKnownPoses, already possible with FeatureMatching+Triangulation.

@mugulmd mugulmd changed the title [nodes] new Triangulate node [nodes] new SfMTriangulation node Jan 4, 2023
@fabiencastan fabiencastan added this to the Meshroom 2023.1.0 milestone Jan 14, 2023
@fabiencastan fabiencastan merged commit 8ab563a into develop Jan 14, 2023
@fabiencastan fabiencastan deleted the dev/triangulate_only branch January 14, 2023 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants