Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OpenAISettingsBuilder #191

Merged
merged 3 commits into from
Aug 15, 2024
Merged

Add OpenAISettingsBuilder #191

merged 3 commits into from
Aug 15, 2024

Conversation

justinyoo
Copy link
Contributor

Related to #166 #161

This PR is:

  • To add OpenAISettingsBuilder class that buids the OpenAISettings instance.

@justinyoo justinyoo self-assigned this Aug 15, 2024
Copy link

Test Results

✔️ Tests 7 / 7 - passed in 18s
📝 Coverage 0%
📏 0 / 173 lines covered 🌿 0 / 18 branches covered
🔍 click here for more details

Copy link

Test Results

Tests

📋 Total ✔️ Passed ❌ Failed ⚠️ Skipped
7 7 0 0

Coverage

📏 Line 🌿 Branch
0 / 173 (0%) 0 / 18 (0%)

@justinyoo justinyoo linked an issue Aug 15, 2024 that may be closed by this pull request
Copy link
Contributor Author

@justinyoo justinyoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both interface and class need to be updated

/// </summary>
public class OpenAISettingsBuilder : IOpenAISettingsBuilder
{
private OpenAISettings? _settings;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no way to set this field value. Maybe changing it to the list of OpenAIInstanceSettings and inject it from outside?

- To add list of OpenAI access details
Copy link

Test Results

✔️ Tests 12 / 12 - passed in 18.7s
📝 Coverage 0%
📏 0 / 173 lines covered 🌿 0 / 18 branches covered
🔍 click here for more details

✏️ updated for commit 2ad2f35

Copy link

Test Results

Tests

📋 Total ✔️ Passed ❌ Failed ⚠️ Skipped
12 12 0 0

Coverage

📏 Line 🌿 Branch
0 / 173 (0%) 0 / 18 (0%)

@justinyoo justinyoo merged commit c9904d2 into main Aug 15, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Backend API] Builder pattern that returns OpenAISettings
1 participant