-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OpenAISettingsBuilder
#191
Merged
Merged
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
31 changes: 31 additions & 0 deletions
31
src/AzureOpenAIProxy.ApiApp/Builders/OpenAISettingsBuilder.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
using AzureOpenAIProxy.ApiApp.Configurations; | ||
|
||
namespace AzureOpenAIProxy.ApiApp.Builders; | ||
|
||
/// <summary> | ||
/// This provides interface to the <see cref="OpenAISettingsBuilder"/> class. | ||
/// </summary> | ||
public interface IOpenAISettingsBuilder | ||
{ | ||
/// <summary> | ||
/// Builds the <see cref="OpenAISettings"/> instance. | ||
/// </summary> | ||
/// <returns>Returns the <see cref="OpenAISettings"/> instance.</returns> | ||
OpenAISettings Build(); | ||
} | ||
|
||
/// <summary> | ||
/// This represents the builder entity for <see cref="OpenAISettings"/> class. | ||
/// </summary> | ||
public class OpenAISettingsBuilder : IOpenAISettingsBuilder | ||
{ | ||
private OpenAISettings? _settings; | ||
|
||
/// <inheritdoc /> | ||
public OpenAISettings Build() | ||
{ | ||
this._settings ??= new OpenAISettings(); | ||
|
||
return this._settings; | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
22 changes: 22 additions & 0 deletions
22
test/AzureOpenAIProxy.ApiApp.Tests/Builders/OpenAISettingsBuilderTests.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
using AzureOpenAIProxy.ApiApp.Builders; | ||
using AzureOpenAIProxy.ApiApp.Configurations; | ||
|
||
using FluentAssertions; | ||
|
||
namespace AzureOpenAIProxy.ApiApp.Tests.Builders; | ||
|
||
public class OpenAISettingsBuilderTests | ||
{ | ||
[Fact] | ||
public void Given_OpenAISettingsBuilder_When_Invoked_Build_Then_It_Should_Return_Instance() | ||
{ | ||
// Arrange | ||
var builder = new OpenAISettingsBuilder(); | ||
|
||
// Act | ||
var result = builder.Build(); | ||
|
||
// Assert | ||
result.Should().NotBeNull().And.BeOfType<OpenAISettings>(); | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's no way to set this field value. Maybe changing it to the list of
OpenAIInstanceSettings
and inject it from outside?