Fix Actions to skip S3 tests from external contributors

[soldni]

This would make the failures for #23 and #24 go away.

Having external collaborators hit the test bucket is a security risk, so those tests should be skipped.

[chris-ha458]

This would be helpful!
Some reproducible and accessible data, even if it requires some work on the external collaborators part, could be a reasonable alternative as well.

Also, If S3 access is crucial even for outside cotnributors there are some world-readable-free aws buckets such as PMC Open Access (OA) Subset on AWS s3://pmc-oa-opendata
I am not sure if it is acceptable access to use it for this purpose. (If I had to guess it would be no)

[soldni]

That's an interesting idea! Some of the tests require buckets to be writable, so we need to skip some anyway, but it would be nice to keep at least some of the tests.

…

On Aug 21, 2023 at 06:06:40, Chris Ha ***@***.***> wrote: This would be helpful! Some reproducible and accessible data, even if it requires some work on the external collaborators part, could be a reasonable alternative as well. Also, If S3 access is crucial even for outside cotnributors there are some world-readable-free aws buckets such as PMC Open Access (OA) Subset on AWS <https://www.ncbi.nlm.nih.gov/pmc/tools/pmcaws/> s3://pmc-oa-opendata I am not sure if it is acceptable access to use it for this purpose. (If I had to guess it would be no) — Reply to this email directly, view it on GitHub <#27 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA53OIQXNQHPKEQJTG6HBJDXWNMOBANCNFSM6AAAAAA3XSWFBM> . You are receiving this because you were assigned.Message ID: ***@***.***>

[chris-ha458]

Also is this issue that is blocking the assessment and merging of those two PRs at this time?
I am planning further commits upon those changes, if they cannot be integrated before this is addressed, I would rather assist in developing or testing this issue to help move things along.

[soldni]

@chris-ha458 I think the fixed I just merged in main should do it. if you have time to rebase, it would be great!

[soldni]

ok looks like it worked for #24 ! closing this issue.