fix rust parts #23
fix rust parts #23
Conversation
|
I would really love a proper contributing.md document styleguide and precommit. |
|
I know that |
fix for more idiomatic code. also, this variable likely would not need to be investigated further than this.
if you think about it we don't even need to keep the response in memory since we are only looking for the size
simpler string formatting
changing the unwrap was more involved but i think it became better https://rust-lang.github.io/rust-clippy/master/index.html#/unnecessary_unwrap
The long unwrap chain can also be fixed but it's also a matter of error management so i'm keeping it as is https://rust-lang.github.io/rust-clippy/master/index.html#/single_match
Not all borrows are needless in this context but if the traits are implemented in a way (either by default or by the code) that automatically copies, when the reference is immediately used and never used again, & might be unnecessary https://rust-lang.github.io/rust-clippy/master/index.html#/needless_borrow
expect CAN be idiomatic but this does not seem to be the case here. https://rust-lang.github.io/rust-clippy/master/index.html#/expect_fun_call
fix for more idiomatic code. also, this variable likely would not need to be investigated further than this.
we're skipping the okay case so we only need to check the Err(e) case
|
@rodneykinney can u take a look? thank you!! |
note that `bits` can (and should) be immutable now. this is because after initialization, no `AtomicU32`s are added nor removed from `bits` We are instead relying on interior mutability of the `Vec` through the internal type `AtomicU32` https://doc.rust-lang.org/reference/interior-mutability.html
you can remove the panic here if you still want to run to propagate error somehow from here
we want to retrieve the unwrapped line here. If it is Ok(line) it is unwrapped. if it is Err(e) we log the line_number, doc location and error e. end then we break, specifically the line processing loop
consolidate it into one function
? is idiomatic to replace match that is used only to propagate errors
to_string is infallible(cannot fail and checked during conpile) for string literal
we still have the unwrap, which could be removed as well but this is as concise while leaving the unwrap there
|
I know i've been making more changes since the approval, but unless otherwise stated, A few that actually change behavior are removing unwrap() as much as possible, |
|
@chris-ha458 looks great! I've merged in. |
either the type should change or the operator should.
It seems the operator should change and document the setting information for future reference
https://rust-lang.github.io/rust-clippy/master/index.html#/absurd_extreme_comparisons