Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to windows 0.39.0 #21

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Frederick888
Copy link

Just got hit by the security alert. Since there hasn't been any news at
#18 for a while, here's another one to bump it directly to 0.37.0.

@Frederick888 Frederick888 marked this pull request as ready for review June 17, 2022 13:15
@MeerMusik
Copy link

@allenbenz

Hello. I hope it is only time that prevents you from working on this Project and ignoring Merge Requests?

As other Projects rely on this currently:

If you do not have time (currently / anymore) for whatever reason to work on this, it would be nice to update the ReadMe or create a pinned Issue and let People know.

This cloud help that someone(TM) maybe Fork it and become the new Maintainer and create a new official Crate, or you could try to find a Maintainer for this Repo officially.

Thank you in advance and have a nice Day!

@Frederick888 Frederick888 changed the title Upgrade to windows 0.37.0 Upgrade to windows 0.38.0 Jul 14, 2022
@Frederick888 Frederick888 changed the title Upgrade to windows 0.38.0 Upgrade to windows 0.39.0 Jul 23, 2022
@izzy
Copy link

izzy commented Aug 2, 2022

Is this going to see any updates? I'm using a larger framework, which is using this lib, which in turn is using the outdated windows lib that throws security errors.

Given that this lib hasn't seen an update since January, the maintainer has had no activity on GH since March and has no contact info on their GH profile I think some clarification on the status of this project would be nice, so upstream maintainers can decide on how to deal with the downstream security issue in windows.

@MeerMusik
Copy link

MeerMusik commented Aug 2, 2022

Is this going to see any updates? I'm using a larger framework, which is using this lib, which in turn is using the outdated windows lib that throws security errors.

Given that this lib hasn't seen an update since January, the maintainer has had no activity on GH since March and has no contact info on their GH profile I think some clarification on the status of this project would be nice, so upstream maintainers can decide on how to deal with the downstream security issue in windows.

Well you said it yourself:
The Admin / Maintainer of this Repo does not react so far. Your only hope currently IMHO is, to create an Issue in the Repo of the Framework you are using, tell them what is going on and also at the same time, asks them to remove any Dependency to this crate or alternatively add that Functionality directly to the Framework - in one way or another.

This is what I would do, if I choose for example Tauri (the Framework I am testing) and Rust instead of Wails and Go (Golang).

As I have not yet decided which Framework I am going to use, I have not created a Report at the Tauri Repo myself so far.

Another Alternative: Someone(TM) else creates a Fork of this Repo and upload / publish it as a new Crate. But so far there seems no one (myself included) to either have the time, knowledge and or interest to do this.

@Frederick888
Copy link
Author

Alternatively someone can backport microsoft/windows-rs@afe3252 to 0.24.0 and release it as 0.24.1, which is probably more efficient in terms of tackling this particular security issue.

@kmod-midori
Copy link

During my recent development on a side project, I came across this project, which has been quite useful. However, I needed some more advanced features in Windows's toast APIs (such as header and some callbacks), so I wrote this crate and just published it. It is still somehow incomplete, but certainly usable.

It also contains registration code ported from Microsoft's community toolkit, so you will no longer need the PowerShell workaround and can directly register your application.

If you are a direct user of this crate, feel free to try out my crate (documentation might take some more time to build and show up).

@Frederick888
Copy link
Author

There's also news at hoodie/notify-rust#148

@BeiyanYunyi
Copy link

@chengyuhui My notify-win-rs is relying on your winrt-toast now, come on!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants