Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

winrt-notification is not maintained #148

Closed
lucasfernog opened this issue Aug 13, 2022 · 5 comments
Closed

winrt-notification is not maintained #148

lucasfernog opened this issue Aug 13, 2022 · 5 comments

Comments

@lucasfernog
Copy link
Contributor

The winrt-notification does not seem to be maintained and uses an outdated and vulnerable windows version (see the GitHub advisory). The tauri team is considering forking it, would you accept a PR to use it instead of the outdated crate? We could also merge it with win7-notifications to add Windows 7 support to notify-rust.
@lucasfernog lucasfernog mentioned this issue Aug 13, 2022
Closed
@hoodie
Copy link
Owner

hoodie commented Aug 13, 2022

sounds good to me

@lucasfernog
Copy link
Contributor Author

We're discussing which windows-rs version it should use. v0.34 still compiles on Rust 1.56 (the current MSRV for notify-rust) but latest version requires Rust 1.59. Do you have an opinion on this? Should we keep the MSRV as is?

@Frederick888 Frederick888 mentioned this issue Aug 18, 2022
Open
@hoodie
Copy link
Owner

hoodie commented Aug 24, 2022 •
edited
Loading

1.56 is already quite old, we can raise it to something higher than that. I usually looked at what something like tokio currently requires. The minimum is what ships with debian, but we can have a separate MSRV for windows if necessary.

@lucasfernog
Copy link
Contributor Author

Ok we'll publish our fork soon.

@lucasfernog
Copy link
Contributor Author

Fork published: https://crates.io/crates/tauri-winrt-notification do you want me to submit a PR?

@hoodie hoodie closed this as completed in 99e7340 Sep 21, 2022
hoodie added a commit that referenced this issue Sep 21, 2022
@hoodie
Merge pull request #149 from lucasfernog/feat/update-winrt-notification
111052f 
feat: update winrt-notification to a maintained fork, closes #148
hoodie pushed a commit that referenced this issue Sep 21, 2022
@lucasfernog @hoodie
fix: update winrt-notification to a maintained fork, closes #148
6915513
hoodie pushed a commit that referenced this issue Sep 21, 2022
@lucasfernog @hoodie
fix: update winrt-notification to a maintained fork, closes #148
7cc6824
Frederick888 added a commit to Frederick888/git-credential-keepassxc that referenced this issue Sep 22, 2022
@Frederick888
fix: Address windows crate vulnerability
0084e80 
It was fixed in [1]. And notify-rust introduced this fix in [2].

[1] microsoft/windows-rs@afe3252
[2] hoodie/notify-rust#148 (comment)
@github-actions github-actions bot mentioned this issue Sep 22, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hoodie @lucasfernog