Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update winrt-notification to a maintained fork, closes #148 #149

Merged
merged 1 commit into from
Sep 21, 2022
Merged

feat: update winrt-notification to a maintained fork, closes #148 #149

merged 1 commit into from
Sep 21, 2022

Conversation

lucasfernog
Copy link
Contributor

@lucasfernog lucasfernog commented Sep 4, 2022

This PR updates the winrt-notification dependency to use tauri-winrt-notification, a fork we will maintain until the original author is able to fix a security vulnerability that exists because of an outdated windows version.

This fork updates the windows dependency to 0.39.0, which requires Rust 1.59.0. Other operating systems are not affected by it so that's why I kept the original MSRV in the Cargo manifest.

@lucasfernog
Copy link
Contributor Author

And looks like we need to pin zvariant_derive and time, at least on CI. Maybe we should remove zvariant_derive in order to keep the current MSRV.

@lucasfernog
Copy link
Contributor Author

@hoodie

@hoodie hoodie merged commit 111052f into hoodie:main Sep 21, 2022
@lucasfernog lucasfernog deleted the feat/update-winrt-notification branch September 23, 2022 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants