feat(rpc-types-beacon): BuilderBlockValidationRequestV3
#1310
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I'd like to add support for
flashbots_validateBuilderSubmissionV3
to reth, but we need theBuilderBlockValidationRequestV3
for the rpc request param.Solution
This adds the aforementioned struct. Note that the new struct does not contain the
withdrawls_root
field present inV2
. I went through the latest flashbots/builder code and this parameter was removed from theV2
requests, and is not present inV3
:https://github.com/flashbots/builder/blob/7577ac81da21e760ec6693637ce2a81fe58ac9f8/eth/block-validation/api.go#L198-L202
Furthermore the ultrasoundmoney implementation doesn't contain it either: https://github.com/ultrasoundmoney/reth-payload-validator/blob/main/src/rpc/types.rs#L12-L20
I did not remove it from the
BuilderBlockValidationRequestV2
struct since that's potentially a breaking change, which seemed worth avoiding.Finally, I'm unsure if I should add a
BuilderBlockValidationRequestV4
for Pectra: sincerequest
is aSubmitBlockRequest
which uses theExecutionPayload
enum theV3
andV4
structs would have the exact same fields. Alternatively, we could addSubmitBlockRequestV3/V4
structs that use the explicitExecutionPayloadV3/V4
structs instead of the enum, but that would break the pattern established inV2
.PR Checklist