feat(rpc-types-beacon): BuilderBlockValidationRequestV4
#1322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanschneider
requested review from
DaniPopes,
gakonst,
mattsse,
onbjerg,
prestwich and
emhane
as code owners
that makes sense an enum also makes sense |
mattsse
approved these changes
Sep 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As suggested by @mattsse here this is a simple type alias for
BuilderBlockValidationRequestV4.I still think we should consider refactoring these structs to use an explicit versioned
ExecutionPayloadV*instead of the enum, but I'm not sure how we feel about breaking compat on the V1 and V2 structs.We could also move them from
::relayto::validationto mirror the layout in reth: https://github.com/paradigmxyz/reth/blob/3daec1d9b97c2d654c7f84e8521ac552dcaf4928/crates/rpc/rpc-api/src/validation.rsSolution
Anyways the type alias works for Pectra in the short-term, but happy to make the other changes if people are ok with that.
PR Checklist