Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(serde): remove deprecated num module #1350

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Conversation

DaniPopes
Copy link
Member

Deprecated over 3 months ago in #855.

Unfortunately the #[deprecated] attribute warnings don't show if used inside of #[serde(...)] so this may cause more breakage than it should.

@@ -89,6 +89,48 @@ pub mod vec {
}
}

/// serde functions for handling `Vec<Vec<u128>>` via [U128](alloy_primitives::U128)
pub mod u128_vec_vec_opt {
Copy link
Member Author

@DaniPopes DaniPopes Sep 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just moved, no other changes in this file

Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reasonable

@DaniPopes DaniPopes merged commit 0610864 into main Sep 24, 2024
26 checks passed
@DaniPopes DaniPopes deleted the dani/rm-serde-num branch September 24, 2024 15:32
lwedge99 pushed a commit to sentioxyz/alloy that referenced this pull request Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants