feat(serde): deprecate individual num::* for a generic quantity module
#855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaniPopes
requested review from
gakonst,
mattsse,
onbjerg,
prestwich and
Evalir
as code owners
DaniPopes
force-pushed
the
dani/generic-serde-quantity
branch
from
33ef3c4
to
f41d218
Compare
|
I don't mind the name |
DaniPopes
force-pushed
the
dani/generic-serde-quantity
branch
from
f41d218
to
326e9ff
Compare
DaniPopes
force-pushed
the
dani/generic-serde-quantity
branch
from
75d64d3
to
313f378
Compare
prestwich
approved these changes
Jun 8, 2024
Evalir
approved these changes
Jun 8, 2024
mattsse
approved these changes
Jun 9, 2024
Co-authored-by: evalir <hi@enriqueortiz.dev>
ben186
pushed a commit
to ben186/alloy
that referenced
this pull request
Jul 27, 2024
…ule (alloy-rs#855) * feat(serde): deprecate individual num::* for a generic `quantity` module * docs: document byte format * Update quantity.rs Co-authored-by: evalir <hi@enriqueortiz.dev> --------- Co-authored-by: evalir <hi@enriqueortiz.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Highlights that this is Ethereum JSON-RPC
quantityencoding, removesruintfrom the name, and makes it genericUnfortunately
#[deprecated]does not emit any warnings forserde(with = "...")invocations