feat(consensus): Protected Legacy Signature #1578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refcell
force-pushed
the
rf/feat/protected
branch
from
b7a9368
to
9903778
Compare
refcell
requested review from
DaniPopes,
gakonst,
mattsse,
onbjerg and
emhane
as code owners
klkvr
reviewed
Oct 28, 2024
Comment on lines
+193
to
+207
| /// Returns true if the signature of the transaction is protected. | ||
| #[inline] | ||
| pub const fn is_protected(&self) -> bool { | ||
| match self { | ||
| Self::Legacy(tx) => { | ||
| let v = tx.signature().v().to_u64(); | ||
| if 64 - v.leading_zeros() <= 8 { | ||
| return v != 27 && v != 28 && v != 1 && v != 0; | ||
| } | ||
| // anything not 27 or 28 is considered protected | ||
| true | ||
| } | ||
| _ => true, | ||
| } | ||
| } |
There was a problem hiding this comment.
should this be false for non-legacy?
There was a problem hiding this comment.
No, see the reference impl in kona
There was a problem hiding this comment.
Here is the reference impl in optimism's op-node
klkvr
approved these changes
Oct 28, 2024
This was referenced Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a method to the
TxEnvelopetype that returns if the associated signature is protected.