Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: clearer replay protection checks #1581

Merged
merged 3 commits into from
Oct 30, 2024
Merged

fix: clearer replay protection checks #1581

merged 3 commits into from
Oct 30, 2024

Conversation

prestwich
Copy link
Member

@prestwich prestwich commented Oct 29, 2024 •
edited
Loading

followup to #1578

Motivation

#1578 is poorly documented, doesn't specify what's protected in the API, and includes math that is already implemented elsewhere

Solution

Clean up

  • add documentation with relevant EIP link
  • make naming unambiguous ("protected from what?")
  • use functions math from the existing Parity object

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@prestwich prestwich changed the title fix: replay protection checks fix: clearer replay protection checks Oct 29, 2024
@prestwich prestwich mentioned this pull request Oct 29, 2024
Merged
3 tasks
onbjerg
onbjerg approved these changes Oct 29, 2024
View reviewed changes
Copy link
Member

@onbjerg onbjerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

much better, ty

@yash-atreya yash-atreya merged commit 329c897 into main Oct 30, 2024
26 checks passed
@yash-atreya yash-atreya deleted the prestwich/fix-replay-protection branch October 30, 2024 13:18
@DaniPopes DaniPopes mentioned this pull request Oct 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onbjerg onbjerg onbjerg approved these changes

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

@emhane emhane Awaiting requested review from emhane emhane is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@prestwich @onbjerg @yash-atreya