fix(rpc-types): FeeHistory deser
#1629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yash-atreya
requested review from
DaniPopes,
gakonst,
mattsse,
onbjerg and
emhane
as code owners
mattsse
approved these changes
Nov 6, 2024
crates/rpc-types-eth/src/fee.rs
Outdated
| @@ -45,6 +45,7 @@ pub struct FeeHistory { | |||
| pub base_fee_per_gas: Vec<u128>, | |||
| /// An array of block gas used ratios. These are calculated as the ratio | |||
| /// of `gasUsed` and `gasLimit`. | |||
| #[cfg_attr(feature = "serde", serde(deserialize_with = "gas_used_ratio_deser::deserialize"))] | |||
There was a problem hiding this comment.
I believe we have this in alloy-serde:
alloy/crates/serde/src/optional.rs
Line 7 in caa380d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently we don't correctly handle a
eth_feeHistoryresponse in whichgasUsedRatioisnull.Solution
Handle this case by deserializing to an empty vec.
PR Checklist