chore(sidecar): bump alloy version to 0.6.3 #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merklefruit
commented
Nov 12, 2024
Comment on lines
+125
to
+128
| let parent_beacon_block_root = B256::from_slice( | ||
| // TODO: compat: as_slice() from_slice() is necessary until we bump ethereum-consensus | ||
| // version to match alloy's. | ||
| self.beacon_api_client.get_beacon_block_root(BlockId::Head).await?.as_slice(), |
bolt-sidecar/src/crypto/ecdsa.rs
Outdated
Comment on lines
77
to
79
| // TODO: compat: this is necessary since alloy PrimitiveSignature and Signature | ||
| // are different types in the new version | ||
| Ok(AlloySignature::try_from(sig.as_bytes().as_ref()).unwrap()) |
thedevbirb
requested changes
Nov 13, 2024
thedevbirb
approved these changes
Nov 13, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A node operator has encountered an edge case in Geth's
eth_feeHistoryendpoint.After some digging it turns out that this was a bug in Alloy's deserialization of the
FeeHistoryresult.It has already been fixed in Alloy last week here: alloy-rs/alloy#1629
but we need to bump alloy in the sidecar in order to inherit it.
This was due at some point, so here we go :)
Note: this also bumps the sidecar's toolchain to 1.82.0