Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

impl ConvertRuint for U256 to be compatible with alloy_serde #1661

Closed
wants to merge 1 commit into from
Closed

impl ConvertRuint for U256 to be compatible with alloy_serde #1661

wants to merge 1 commit into from

Conversation

DougieHauser
Copy link

Adding the ConvertRuint trait to apply to the non-primitive type of U256,
this is a first step towards fixing issue 85 in op-alloy

This is my 1st contribution ever.. be gentle :)

@DaniPopes
Copy link
Member

Thanks but this is not needed, you can simply remove the serde(with = "quantity") attribute since quantity should only used for non-ruint integers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@emhane emhane Awaiting requested review from emhane emhane is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DougieHauser @DaniPopes