Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Use U256 instead of u128 for mint #85

Open
yash-atreya opened this issue Sep 9, 2024 · 3 comments
Open

[Feature] Use U256 instead of u128 for mint #85

yash-atreya opened this issue Sep 9, 2024 · 3 comments
Labels
A-consensus Area: consensus crate A-rpc-types Area: op alloy rpc types good-first-issue Issues that are easy to pick up for new contributors

Comments

@yash-atreya
Copy link
Member

Component

rpc-types

Describe the feature you would like

          wondering if `mint` should be `U256` instead in op-alloy as this is basically same as `value`

Originally posted by @klkvr in foundry-rs/foundry#8595 (comment)

Make mint field U256 in the following places

  1. pub mint: Option<u128>,

Additional context

No response

@yash-atreya yash-atreya added A-consensus Area: consensus crate A-rpc-types Area: op alloy rpc types good-first-issue Issues that are easy to pick up for new contributors labels Sep 9, 2024
@programskillforverification
Copy link
Contributor

It should be U256 in op-alloy

@reymom
Copy link

reymom commented Oct 23, 2024

Is this still open?

@mahmudsudo
Copy link

Hi , can i take on this issue ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-consensus Area: consensus crate A-rpc-types Area: op alloy rpc types good-first-issue Issues that are easy to pick up for new contributors
Projects
None yet
Development

No branches or pull requests

4 participants