Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace anvil OP types with op-alloy #8595

Conversation

programskillforverification
Copy link
Contributor

Motivation

close #8575

Solution

Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should be able to replace the anvil deposit type entirely with the op-alloy I think?

@programskillforverification
Copy link
Contributor Author

we should be able to replace the anvil deposit type entirely with the op-alloy I think?

All struct fields name is the same as op-alloy?

@zerosnacks
Copy link
Member

Just a heads up - due to duplicate tickets we may have double assigned this task, if we end up having a PR for #6860 by @leovct I'll make sure to tag @programskillforverification as co-author

@leovct
Copy link
Contributor

leovct commented Sep 24, 2024

Just a heads up - due to duplicate tickets we may have double assigned this task, if we end up having a PR for #6860 by @leovct I'll make sure to tag @programskillforverification as co-author

No problem at all. I started to work on it but it's not done, I can give it to @programskillforverification :)

@programskillforverification
Copy link
Contributor Author

Just a heads up - due to duplicate tickets we may have double assigned this task, if we end up having a PR for #6860 by @leovct I'll make sure to tag @programskillforverification as co-author

This PR has been opened for a long time, I think all is done but maybe not. I don't get what @mattsse mean. Could you give me more detail, like what't left to do. I hope finish this assign asap.

@yash-atreya
Copy link
Member

Superseded by #9047

@yash-atreya yash-atreya closed this Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

replace anvil OP types with op-alloy
6 participants