Skip to content

Commit

Permalink
chore(general): add basic CI workflow for Windows (#613)
Browse files Browse the repository at this point in the history
add basic windows CI workflow

use 1.76, attempt to run all flags

Update ci.yml

Co-authored-by: DaniPopes <57450786+DaniPopes@users.noreply.github.com>

revert update to 1.76, use 1.65. no need to use nextest here

use conditional compilation based on keccak-asm support table with tiny_keccak fallback

handle conditional use of asm-keccak based on support table

update workflow, make sure to define OS for mrsv

avoid conditonal compilation in code, handle in TOML

instead of conditonal compilation restrict test targets to known good features

reshape matrix

fix nesting

disable other tasks for now

fix naming

use os.flags

attempt fix

fix

debug

define os

attempt test fix for windows

avoid running abigen ui on windows

compile, just ignore

readd rest of config

fix formatting
  • Loading branch information
zerosnacks authored Apr 29, 2024
1 parent 1cb55a8 commit a697c4a
Show file tree
Hide file tree
Showing 2 changed files with 33 additions and 11 deletions.
42 changes: 32 additions & 10 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,21 +14,43 @@ concurrency:

jobs:
test:
name: test ${{ matrix.rust }} ${{ matrix.flags }}
runs-on: ubuntu-latest
name: test ${{ matrix.os }} ${{ matrix.rust }} ${{ matrix.flags }}
runs-on: ${{ matrix.os }}
timeout-minutes: 30
strategy:
fail-fast: false
matrix:
rust: ["stable", "beta", "nightly"]
flags: ["--no-default-features", "", "--all-features"]
os: ["ubuntu-latest", "windows-latest"]
rust: [
"stable",
"beta",
"nightly",
"1.65" # MSRV
]
flags: [
# No features
"--no-default-features",
# Default features
""
]
include:
- rust: "1.65" # MSRV
flags: "--no-default-features"
- rust: "1.65" # MSRV
flags: ""
- rust: "1.65" # MSRV
# MSRV features
- os: "ubuntu-latest"
rust: "1.65" # MSRV
flags: "--features json"
- os: "windows-latest"
rust: "1.65" # MSRV
flags: "--features json"
# All features
- os: "ubuntu-latest"
rust: "stable"
flags: "--all-features"
- os: "ubuntu-latest"
rust: "beta"
flags: "--all-features"
- os: "ubuntu-latest"
rust: "nightly"
flags: "--all-features"
steps:
- uses: actions/checkout@v4
- uses: dtolnay/rust-toolchain@master
Expand Down Expand Up @@ -125,4 +147,4 @@ jobs:
- uses: dtolnay/rust-toolchain@nightly
with:
components: rustfmt
- run: cargo fmt --all --check
- run: cargo fmt --all --check
2 changes: 1 addition & 1 deletion crates/sol-types/tests/compiletest.rs
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#[rustversion::attr(not(nightly), ignore)]
#[cfg_attr(miri, ignore)]
#[cfg_attr(any(target_os = "windows", miri), ignore)]
#[test]
fn ui() {
let t = trybuild::TestCases::new();
Expand Down

0 comments on commit a697c4a

Please sign in to comment.