chore(general): add basic CI workflow for Windows #613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use 1.76, attempt to run all flags Update ci.yml Co-authored-by: DaniPopes <57450786+DaniPopes@users.noreply.github.com> revert update to 1.76, use 1.65. no need to use nextest here use conditional compilation based on keccak-asm support table with tiny_keccak fallback handle conditional use of asm-keccak based on support table update workflow, make sure to define OS for mrsv avoid conditonal compilation in code, handle in TOML instead of conditonal compilation restrict test targets to known good features reshape matrix fix nesting disable other tasks for now fix naming use os.flags attempt fix fix debug define os attempt test fix for windows avoid running abigen ui on windows compile, just ignore readd rest of config fix formatting
zerosnacks
requested review from
DaniPopes,
prestwich and
gakonst
as code owners
DaniPopes
approved these changes
Apr 29, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Related PR in
alloy: alloy-rs/alloy#642Continues from #610
Solution
Implements windows-latest as test target whilst maintaining the current configuration.
For now disables the running of the abigen UI tests due to underlying differences in output not handled by
trybuildSee run example: https://github.com/zerosnacks/core/actions/runs/8878272887
PR Checklist
Notes
coreoffering an explicit fallback.