chore: use crates.io uint, move crates to crates/* (#31)

* chore: use crates.io uint

* chore: move crates to `crates/*`

* test: gate rlp-derive tests behind feature

* fix: gate rlp tests to alloc

* chore: temporarily use git ruint as per #29

Cargo.toml

@@ -1,15 +1,6 @@
 [workspace]
 resolver = "2"
-members = [
-    "abi",
-    "abi/sol-type-parser",
-    "dyn-abi",
-    "primitives",
-    "rlp",
-    "rlp/rlp-derive",
-    "uint",
-    "uint/ruint-macro",
-]
+members = ["crates/*"]
 
 [workspace.package]
 edition = "2021"
@@ -21,14 +12,15 @@ repository = "https://github.com/ethers-rs/core"
 
 [workspace.dependencies]
 # workspace crates
-ethers-abi-enc = { version = "0.1.0", path = "abi", default-features = false }
-sol-type-parser = { version = "0.1.0", path = "abi/sol-type-parser", default-features = false }
-ethers-dyn-abi = { version = "0.1.0", path = "dyn-abi", default-features = false }
-ethers-primitives = { version = "0.1.0", path = "primitives", default-features = false }
-ethers-rlp = { version = "0.1.0", path = "rlp", default-features = false }
-ethers-rlp-derive = { version = "0.1.0", path = "rlp/rlp-derive", default-features = false }
-ruint = { version = "1.0.2", path = "uint", default-features = false }
-ruint-macro = { version = "1.7.0", path = "uint/ruint-macro", default-features = false }
+ethers-abi-enc = { version = "0.1.0", path = "crates/abi", default-features = false }
+ethers-dyn-abi = { version = "0.1.0", path = "crates/dyn-abi", default-features = false }
+ethers-primitives = { version = "0.1.0", path = "crates/primitives", default-features = false }
+ethers-rlp = { version = "0.1.0", path = "crates/rlp", default-features = false }
+ethers-rlp-derive = { version = "0.1.0", path = "crates/rlp-derive", default-features = false }
+ethers-sol-type = { version = "0.1.0", path = "crates/sol-type", default-features = false }
+
+ruint = { version = "1.8.0", git = "https://github.com/recmo/uint", default-features = false }
+ruint-macro = { version = "1.0.2", git = "https://github.com/recmo/uint", default-features = false }
 
 # serde
 serde = { version = "1.0", default-features = false }

abi/Cargo.toml → crates/abi/Cargo.toml

@@ -15,7 +15,7 @@ repository.workspace = true
 
 [dependencies]
 ethers-primitives.workspace = true
-sol-type-parser.workspace = true
+ethers-sol-type.workspace = true
 
 hex = { workspace = true, features = ["alloc"] }
 

abi/src/lib.rs → crates/abi/src/lib.rs

@@ -245,7 +245,7 @@ pub mod no_std_prelude {
 ///
 /// See the root crate docs for more information.
 #[doc(inline)]
-pub use sol_type_parser::sol;
+pub use ethers_sol_type::sol;
 
 /// The Word type for ABI Encoding
 pub type Word = ethers_primitives::B256;

primitives/src/signed/int.rs → crates/primitives/src/signed/int.rs

@@ -520,7 +520,7 @@ mod tests {
         BigIntConversionError, ParseSignedError,
     };
     use ruint::{
-        aliases::{U0, U1, U128, U160, U192, U256},
+        aliases::{U0, U1, U128, U160, U256},
         BaseConvertError, ParseError,
     };
     use std::ops::Neg;
@@ -529,6 +529,9 @@ mod tests {
     type I96 = Signed<96, 2>;
     type U96 = Uint<96, 2>;
 
+    // TODO: ruint::aliases::U192 is bugged
+    type U192 = Uint<192, 3>;
+
     #[test]
     fn identities() {
         macro_rules! test_identities {

rlp/src/decode.rs → crates/rlp/src/decode.rs

@@ -389,12 +389,11 @@ mod alloc_impl {
     }
 }
 
-#[cfg(test)]
+#[cfg(all(test, feature = "alloc"))]
 mod tests {
-    extern crate alloc;
-
     use super::*;
-    use alloc::vec;
+    use alloc::string::String;
+    use alloc::vec::Vec;
     use core::fmt::Debug;
     use hex_literal::hex;
 
@@ -414,10 +413,10 @@ mod tests {
     fn check_decode_list<T, IT>(fixtures: IT)
     where
         T: Decodable + PartialEq + Debug,
-        IT: IntoIterator<Item = (Result<alloc::vec::Vec<T>, DecodeError>, &'static [u8])>,
+        IT: IntoIterator<Item = (Result<Vec<T>, DecodeError>, &'static [u8])>,
     {
         for (expected, mut input) in fixtures {
-            assert_eq!(vec::Vec::<T>::decode(&mut input), expected);
+            assert_eq!(Vec::<T>::decode(&mut input), expected);
             if expected.is_ok() {
                 assert_eq!(input, &[]);
             }

rlp/src/encode.rs → crates/rlp/src/encode.rs

@@ -33,7 +33,8 @@ pub unsafe trait MaxEncodedLenAssoc: Encodable {
 /// Use this to define length of an encoded entity
 ///
 /// # Safety
-/// Invalid value can cause the encoder to crash.
+///
+/// An invalid value can cause the encoder to crash.
 #[macro_export]
 macro_rules! impl_max_encoded_len {
     ($t:ty, $len:expr) => {
@@ -80,85 +81,63 @@ impl<'a, T: ?Sized + Encodable> Encodable for &'a mut T {
     }
 }
 
-#[cfg(feature = "alloc")]
-impl<'a, T: ?Sized + alloc::borrow::ToOwned + Encodable> Encodable for alloc::borrow::Cow<'a, T> {
-    fn encode(&self, out: &mut dyn BufMut) {
-        (**self).encode(out)
-    }
-
-    fn length(&self) -> usize {
-        (**self).length()
-    }
-}
-
-#[cfg(feature = "alloc")]
-impl<T: ?Sized + Encodable> Encodable for alloc::boxed::Box<T> {
+impl Encodable for [u8] {
     fn encode(&self, out: &mut dyn BufMut) {
-        (**self).encode(out)
+        if self.len() != 1 || self[0] >= EMPTY_STRING_CODE {
+            Header {
+                list: false,
+                payload_length: self.len(),
+            }
+            .encode(out);
+        }
+        out.put_slice(self);
     }
 
     fn length(&self) -> usize {
-        (**self).length()
+        let mut len = self.len();
+        if self.len() != 1 || self[0] >= EMPTY_STRING_CODE {
+            len += length_of_length(self.len());
+        }
+        len
     }
 }
 
-#[cfg(feature = "alloc")]
-impl<T: ?Sized + Encodable> Encodable for alloc::rc::Rc<T> {
+impl<const N: usize> Encodable for [u8; N] {
     fn encode(&self, out: &mut dyn BufMut) {
-        (**self).encode(out)
+        Encodable::encode(&self[..], out)
     }
 
     fn length(&self) -> usize {
-        (**self).length()
+        Encodable::length(&self[..])
     }
 }
 
-#[cfg(feature = "alloc")]
-impl<T: ?Sized + Encodable> Encodable for alloc::sync::Arc<T> {
+impl Encodable for str {
     fn encode(&self, out: &mut dyn BufMut) {
-        (**self).encode(out)
+        Encodable::encode(self.as_bytes(), out)
     }
 
     fn length(&self) -> usize {
-        (**self).length()
+        Encodable::length(self.as_bytes())
     }
 }
 
-impl Encodable for [u8] {
-    fn length(&self) -> usize {
-        let mut len = self.len();
-        if self.len() != 1 || self[0] >= EMPTY_STRING_CODE {
-            len += length_of_length(self.len());
-        }
-        len
-    }
-
-    fn encode(&self, out: &mut dyn BufMut) {
-        if self.len() != 1 || self[0] >= EMPTY_STRING_CODE {
-            Header {
-                list: false,
-                payload_length: self.len(),
-            }
-            .encode(out);
-        }
-        out.put_slice(self);
-    }
+unsafe impl<const N: usize> MaxEncodedLenAssoc for [u8; N] {
+    const LEN: usize = N + length_of_length(N);
 }
 
-impl<const LEN: usize> Encodable for [u8; LEN] {
+impl Encodable for bool {
+    #[inline]
     fn length(&self) -> usize {
-        (self as &[u8]).length()
+        1
     }
 
+    #[inline]
     fn encode(&self, out: &mut dyn BufMut) {
-        (self as &[u8]).encode(out)
+        out.put_u8(*self as u8)
     }
 }
 
-unsafe impl<const LEN: usize> MaxEncodedLenAssoc for [u8; LEN] {
-    const LEN: usize = LEN + length_of_length(LEN);
-}
-
 macro_rules! encodable_uint {
     ($t:ty) => {
         #[allow(clippy::cmp_owned)]
@@ -213,16 +192,6 @@ max_encoded_len_uint!(u64);
 encodable_uint!(u128);
 max_encoded_len_uint!(u128);
 
-impl Encodable for bool {
-    fn length(&self) -> usize {
-        (*self as u8).length()
-    }
-
-    fn encode(&self, out: &mut dyn BufMut) {
-        (*self as u8).encode(out)
-    }
-}
-
 impl_max_encoded_len!(bool, { <u8 as MaxEncodedLenAssoc>::LEN });
 
 #[cfg(feature = "std")]
@@ -271,6 +240,46 @@ mod std_support {
 mod alloc_support {
     use super::*;
 
+    impl<'a, T: ?Sized + alloc::borrow::ToOwned + Encodable> Encodable for alloc::borrow::Cow<'a, T> {
+        fn encode(&self, out: &mut dyn BufMut) {
+            (**self).encode(out)
+        }
+
+        fn length(&self) -> usize {
+            (**self).length()
+        }
+    }
+
+    impl<T: ?Sized + Encodable> Encodable for alloc::boxed::Box<T> {
+        fn encode(&self, out: &mut dyn BufMut) {
+            (**self).encode(out)
+        }
+
+        fn length(&self) -> usize {
+            (**self).length()
+        }
+    }
+
+    impl<T: ?Sized + Encodable> Encodable for alloc::rc::Rc<T> {
+        fn encode(&self, out: &mut dyn BufMut) {
+            (**self).encode(out)
+        }
+
+        fn length(&self) -> usize {
+            (**self).length()
+        }
+    }
+
+    impl<T: ?Sized + Encodable> Encodable for alloc::sync::Arc<T> {
+        fn encode(&self, out: &mut dyn BufMut) {
+            (**self).encode(out)
+        }
+
+        fn length(&self) -> usize {
+            (**self).length()
+        }
+    }
+
     impl<T: Encodable> Encodable for alloc::vec::Vec<T> {
         fn length(&self) -> usize {
             list_length(self)
@@ -292,25 +301,15 @@ mod alloc_support {
     }
 }
 
-impl Encodable for &str {
-    fn encode(&self, out: &mut dyn BufMut) {
-        self.as_bytes().encode(out);
-    }
-
-    fn length(&self) -> usize {
-        self.as_bytes().length()
-    }
-}
-
 macro_rules! slice_impl {
     ($t:ty) => {
         impl $crate::Encodable for $t {
-            fn length(&self) -> usize {
-                (&self[..]).length()
+            fn encode(&self, out: &mut dyn BufMut) {
+                Encodable::encode(&self[..], out)
             }
 
-            fn encode(&self, out: &mut dyn bytes::BufMut) {
-                (&self[..]).encode(out)
+            fn length(&self) -> usize {
+                Encodable::length(&self[..])
             }
         }
     };
@@ -391,12 +390,9 @@ pub fn encode_fixed_size<E: MaxEncodedLen<LEN>, const LEN: usize>(v: &E) -> Arra
     out
 }
 
-#[cfg(test)]
+#[cfg(all(test, feature = "alloc"))]
 mod tests {
-    extern crate alloc;
-
     use super::*;
-    use alloc::vec;
     use bytes::BytesMut;
     use hex_literal::hex;
 

rlp/src/lib.rs → crates/rlp/src/lib.rs

@@ -11,6 +11,11 @@
 #[cfg(feature = "alloc")]
 extern crate alloc;
 
+// Used in alloc tests.
+#[cfg(test)]
+#[allow(unused_extern_crates)]
+extern crate hex_literal;
+
 mod decode;
 mod encode;
 mod types;

rlp/tests/derive.rs → crates/rlp/tests/derive.rs

@@ -1,3 +1,5 @@
+#![cfg(feature = "derive")]
+
 use ethers_rlp::*;
 
 #[derive(RlpEncodable, RlpDecodable, RlpMaxEncodedLen, PartialEq, Debug)]

abi/sol-type-parser/Cargo.toml → crates/sol-type/Cargo.toml

@@ -1,5 +1,5 @@
 [package]
-name = "sol-type-parser"
+name = "ethers-sol-type"
 version = "0.1.0"
 description = "Solidity type parsing & generation for the ethers-abi-enc"
 readme = "README.md"

abi/sol-type-parser/README.md → crates/sol-type/README.md

@@ -1,4 +1,4 @@
-# sol-type-parser
+# ethers-sol-type
 
 This crate provides a proc macro that parses solidity types and generates
 SolType types from them. This allows developers to specify complex solidity