Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove ruint submodule, use github ref to ruint #29

Closed
Tracked by #11
prestwich opened this issue May 12, 2023 · 3 comments · Fixed by #31
Closed
Tracked by #11

remove ruint submodule, use github ref to ruint #29

prestwich opened this issue May 12, 2023 · 3 comments · Fixed by #31

Comments

@prestwich
Copy link
Member

No description provided.

@prestwich prestwich mentioned this issue May 12, 2023
Closed
16 tasks
@DaniPopes
Copy link
Member

Why not switch to the main one on crates.io? It's not possible to publish crates with Git deps to the registry

@DaniPopes DaniPopes mentioned this issue May 12, 2023
Merged
@prestwich
Copy link
Member Author

this is a stopgap before ruint@1.9.0 gets released.

ethers-rlp does not need ruint, but we want ruint @ 1.9.0 to depend on ethers-rlp

so the order is release rlp -> update ruint -> use github ref -> publish ruint -> use crates ref

@DaniPopes
Copy link
Member

Using both version = "..." and git = "..." should work then. Git is used locally while version is used when publishing, then once everything's done we can remove git

DaniPopes added a commit that referenced this issue May 12, 2023
@DaniPopes
chore: temporarily use git ruint as per #29
b966024
prestwich pushed a commit that referenced this issue May 12, 2023
@DaniPopes
chore: use crates.io uint, move crates to crates/* (#31)
b69765f 
* chore: use crates.io uint

* chore: move crates to `crates/*`

* test: gate rlp-derive tests behind feature

* fix: gate rlp tests to alloc

* chore: temporarily use git ruint as per #29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: use crates.io uint, move crates to crates/* alloy-rs/core
2 participants
@prestwich @DaniPopes