Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Solidity type parser #181

Merged
merged 25 commits into from
Jul 10, 2023
Merged

feat: Solidity type parser #181

merged 25 commits into from
Jul 10, 2023

Conversation

prestwich
Copy link
Member

@prestwich prestwich commented Jul 7, 2023 •
edited
Loading

supersedes #180

Motivation

Both dyn-abi and json-abi rely on string representations of solidity types

Solution

Break the parser logic from dyn-abi into a new crate both can inherit

  • todo: integrate into json-abi

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@prestwich prestwich added the enhancement New feature or request label Jul 7, 2023
@prestwich prestwich self-assigned this Jul 7, 2023
@prestwich prestwich marked this pull request as ready for review July 9, 2023 20:08
DaniPopes
DaniPopes requested changes Jul 9, 2023
View reviewed changes
crates/dyn-abi/src/lib.rs Show resolved Hide resolved
crates/dyn-abi/src/ty.rs Outdated Show resolved Hide resolved
crates/sol-type-str/Cargo.toml Outdated Show resolved Hide resolved
crates/sol-type-str/src/root.rs Outdated Show resolved Hide resolved
crates/json-abi/src/internal_type.rs Show resolved Hide resolved
crates/dyn-abi/src/resolve.rs Outdated Show resolved Hide resolved
crates/json-abi/src/param.rs Outdated Show resolved Hide resolved
crates/json-abi/src/param.rs Outdated Show resolved Hide resolved
crates/json-abi/src/param.rs Outdated Show resolved Hide resolved
DaniPopes
DaniPopes requested changes Jul 9, 2023
View reviewed changes
crates/dyn-abi/src/resolve.rs Outdated Show resolved Hide resolved
crates/dyn-abi/src/resolve.rs Outdated Show resolved Hide resolved
@DaniPopes DaniPopes mentioned this pull request Jul 9, 2023
Merged
3 tasks
DaniPopes
DaniPopes requested changes Jul 9, 2023
View reviewed changes
Copy link
Member

@DaniPopes DaniPopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after this LGTM. I imagine we can't get the parser types in InternalType because of lifetimes

crates/sol-type-parser/README.md Outdated Show resolved Hide resolved
crates/dyn-abi/src/resolve.rs Outdated Show resolved Hide resolved
crates/json-abi/src/internal_type.rs Outdated Show resolved Hide resolved
crates/json-abi/src/internal_type.rs Outdated Show resolved Hide resolved
@DaniPopes DaniPopes changed the title sol-type-str, but good this time feat: sol-type-str Jul 9, 2023
@DaniPopes DaniPopes changed the title feat: sol-type-str feat: Solidity type parser Jul 9, 2023
@prestwich prestwich merged commit 6fe3636 into main Jul 10, 2023
@DaniPopes DaniPopes deleted the prestwich/sol-typestr branch July 10, 2023 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaniPopes DaniPopes DaniPopes approved these changes

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees

@prestwich prestwich

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@prestwich @DaniPopes