feat(sol-macro): #[sol] attributes and JSON ABI support
#173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaniPopes
commented
Jul 4, 2023
| Self::#variant(inner) => ::core::result::Result::Ok(inner), | ||
| _ => ::core::result::Result::Err(self), | ||
| } | ||
| } |
There was a problem hiding this comment.
cannot be const if destructor cannot be evaluated, so generating this function is useless when we are already generating TryFrom
| @@ -91,8 +91,6 @@ pub(super) fn expand(cx: &ExpCtxt<'_>, s: &ItemStruct) -> Result<TokenStream> { | |||
|
|
|||
| #[allow(non_camel_case_types, non_snake_case, clippy::style)] | |||
| const _: () = { | |||
| use ::alloy_sol_types::private::*; | |||
There was a problem hiding this comment.
this failed with Multicall which has a Result struct because of import ambiguity, we don't need to do glob imports anymore
|
Will rewrite some logic after #181 |
DaniPopes
force-pushed
the
dani/sol-attrs
branch
from
2c11010
to
80e7894
Compare
prestwich
approved these changes
Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #73
Closes #143
Closes #169
Solution
See
sol!docsPR Checklist