fix: MSRV tests #246
Merged
fix: MSRV tests #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaniPopes
force-pushed
the
dani/test-msrv
branch
from
366c12c
to
aa9d7bb
Compare
3 tasks
DaniPopes
force-pushed
the
dani/test-msrv
branch
from
aa9d7bb
to
5933e6e
Compare
DaniPopes
force-pushed
the
dani/test-msrv
branch
from
5933e6e
to
041e0e5
Compare
prestwich
approved these changes
Aug 24, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
clap@4.4.0 updated their MSRV to 1.70.
We build it as part of criterion for our benches.
Solution
Lock them to earlier version, impacts only benches
PR Checklist