Add Uint::iszero method

[tonyke-bot]

This change is to add the Uint::iszero() -> bool method.

Motivation

Current workaround is to use uint_variable.eq(Uint::ZERO) to check if a Uint variable is zero and is not elegant and straightforward enough.

Solution

Add Uint::iszero() -> bool

PR Checklist

• Added Tests
• Added Documentation
• Updated the changelog

[codecov]

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.23% ⚠️

Comparison is base (76f9aa7) 80.51% compared to head (66a1a88) 80.28%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #297      +/-   ##
==========================================
- Coverage   80.51%   80.28%   -0.23%     
==========================================
  Files          54       54              
  Lines        5983     5996      +13     
==========================================
- Hits         4817     4814       -3     
- Misses       1166     1182      +16     

Files Changed	Coverage Δ
src/cmp.rs	100.00% <100.00%> (ø)

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[recmo]

Good idea. I was on the fence on whether to add it or not.
The Rust build in uints don't have it for example, but x == 0 is slightly easier than x == Uint::ZERO. Doing x.is_zero() is a bit more concise.

An open issue is to add support for num-traits ( #226 ) which also includes is_zero().

[tonyke-bot]

Thanks for the prompt review! Just update the PR per your comments.

Would be great to add support for num-traits but let's make it a separated PR if we finally decide to implement it.

[recmo]

Looking good. I started working on num-traits #298 .

[tonyke-bot]

@recmo

MSRV is set to 1.65 but I'm currently failing CI for 1.65 build for this reason:

error: package `clap_builder v4.4.2` cannot be built because it requires rustc 1.70.0 or newer, while the currently active rustc version is 1.65.0
Either upgrade to rustc 1.70.0 or newer, or use
cargo update -p clap_builder@4.4.2 --precise ver
where `ver` is the latest version of `clap_builder` supporting rustc 1.65.0
Error: Process completed with exit code 101.

Can you adjust the MSRV or fix the dependencies so that I can merge this PR?

[prestwich]

it looks like criterion updated deps in a way that broke our MSRV. We can likely go back and pin the dep version we need

cc @DaniPopes to check my beliefs

[DaniPopes]

See alloy-rs/core#246

[tonyke-bot]

Thanks! Borrow @DaniPopes 's idea to fix the 1.65 test with another PR #306

[tonyke-bot]

Unable to merge the PR yet. All request changes should be resolved but GitHub still asking for requested changes to be addressed. Or do @recmo need to approve explicitly?

stale :)

[prestwich]

Unable to merge the PR yet. All request changes should be resolved but GitHub still asking for requested changes to be addressed. Or do @recmo need to approve explicitly?

I went ahead and dismissed his review. This is de minimis and his comments were addressed so I'm pretty confident he'll forgive me for merging