feat: add parsing support for JSON items #329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaniPopes
force-pushed
the
dani/hrparser
branch
from
b367ee0
to
b85006f
Compare
DaniPopes
commented
Oct 3, 2023
prestwich
approved these changes
Oct 3, 2023
|
Small thing about this is that all parse functions use the same parser, so they will accept and ignore stuff like "indexed" and state mutability instead of returning an error, which I don't think is that bad |
gakonst
approved these changes
Oct 4, 2023
Co-authored-by: Georgios Konstantopoulos <me@gakonst.com>
DaniPopes
force-pushed
the
dani/hrparser
branch
from
3409c4a
to
e56c319
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
FromStrandparseassociated functions tojson-abiitems and params.Supersedes #310
Closes #291