refactor(json-abi): remove duplicate item serde hack #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaniPopes
force-pushed
the
dani/simplify-json-serde
branch
from
37c2fc6
to
0950cce
Compare
DaniPopes
added a commit
that referenced
this pull request
Oct 4, 2023
* feat: add parsing support for JSON items * Update crates/json-abi/src/item.rs Co-authored-by: Georgios Konstantopoulos <me@gakonst.com> * feat: add parsing to JsonAbi, address reviews * parse returns kw * doc * parse storage * add storage test * add todo * refactor(json-abi): remove duplicate item serde hack (#330) --------- Co-authored-by: Georgios Konstantopoulos <me@gakonst.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #329
Simplifies serde for items and
AbiItemby usingtag = "type"on the item structs directly.Perf is slightly (2-5%) better for ser, while unchanged for de