Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add RevertReason enum #450

Merged
merged 6 commits into from
Dec 14, 2023
Merged

Conversation

tcoratger
Copy link
Contributor

Motivation

Adding the RevertReason enum addresses the need to encapsulate and distinguish reasons for reverts.

Should close #449.

Solution

Introducing the RevertReason enum offers a structured way to represent both detailed contract errors and raw string messages as reasons for reverts, enhancing clarity and flexibility in error handling within the codebase.

PR Checklist

  • Added Tests
  • Added Documentation

Copy link
Member

@DaniPopes DaniPopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sg

crates/sol-types/src/types/interface/mod.rs Show resolved Hide resolved
crates/sol-types/src/types/interface/mod.rs Outdated Show resolved Hide resolved
Copy link
Member

@DaniPopes DaniPopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DaniPopes DaniPopes merged commit c2f6ad2 into alloy-rs:main Dec 14, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Add RevertReason type
3 participants