Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sol-types): un-break decode revert #457

Merged
merged 3 commits into from
Dec 16, 2023
Merged

Conversation

DaniPopes
Copy link
Member

@DaniPopes DaniPopes commented Dec 16, 2023

Motivation

Avoid breaking change for a patch release. Initially added in #450.

Solution

Use String again as the return type of decode_revert_reason.

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@DaniPopes DaniPopes merged commit e2798c2 into main Dec 16, 2023
21 checks passed
@DaniPopes DaniPopes deleted the dani/unbreak-decode-revert branch December 16, 2023 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants