Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include raw revert reason in debug_ traces #5737

Closed
mattsse opened this issue Dec 12, 2023 · 4 comments
Closed

Include raw revert reason in debug_ traces #5737

mattsse opened this issue Dec 12, 2023 · 4 comments
Assignees
@peyha
Labels
A-rpc Related to the RPC implementation C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started

Comments

@mattsse
Copy link
Collaborator

mattsse commented Dec 12, 2023

Describe the feature

currently we're returning a revert: prefixed error

image

needs alloy-rs/core#449 first
then we need the use the reason without the prefix here:

reth/crates/revm/revm-inspectors/src/tracing/types.rs

Line 350 in 829d3ed

call_frame.revert_reason = decode_revert_reason(self.trace.output.as_ref());

Additional context

No response
@mattsse mattsse added C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started A-rpc Related to the RPC implementation labels Dec 12, 2023
@mattsse mattsse mentioned this issue Dec 12, 2023
Closed
1 task
@peyha
Copy link
Contributor

peyha commented Dec 12, 2023

I'd be happy to handle this one

@peyha
Copy link
Contributor

peyha commented Dec 22, 2023

Should this issue be dropped after this ?

@mattsse
Copy link
Collaborator Author

mattsse commented Dec 22, 2023 •
edited
Loading

I think this is still the case but we can now make this work by using the new RevertReason struct

so we def need a test

@peyha peyha mentioned this issue Dec 23, 2023
Merged
@supernovahs
Copy link
Contributor

Can be closed i think

@mattsse mattsse closed this as completed Jan 2, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@peyha peyha

Labels
A-rpc Related to the RPC implementation C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started
Projects
Reth Tracker
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mattsse @peyha @supernovahs