Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(revm): use GenericRevertReason type #5854

Merged
merged 2 commits into from
Dec 27, 2023
Merged

feat(revm): use GenericRevertReason type #5854

merged 2 commits into from
Dec 27, 2023

Conversation

peyha
Copy link
Contributor

@peyha peyha commented Dec 23, 2023

Intended to solve #5737

@rkrasiuk rkrasiuk added C-enhancement New feature or request A-rpc Related to the RPC implementation labels Dec 25, 2023
mattsse
mattsse approved these changes Dec 27, 2023
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty!

I moved this to a separate function and extracted the revert reason because we don't want to use the display impl for that.

@mattsse mattsse enabled auto-merge December 27, 2023 12:32
@mattsse mattsse added this pull request to the merge queue Dec 27, 2023
Merged via the queue into paradigmxyz:main with commit fba9a59 Dec 27, 2023
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
A-rpc Related to the RPC implementation C-enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@peyha @mattsse @rkrasiuk