Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dyn-abi): derive Eq for TypedData #623

Merged
merged 1 commit into from
May 10, 2024
Merged

feat(dyn-abi): derive Eq for TypedData #623

merged 1 commit into from
May 10, 2024

Conversation

agostbiro
Copy link
Contributor

Motivation

TypeData in ethers_core derives PartialEq and Eq, but it isn't derived in alloy-dyn-abi.

Solution

Derive PartialEq and Eq for TypeData in alloy-dyn-abi.

PR Checklist

  • Added Tests (n/a)
  • Added Documentation (docs are autogenerated for this)
  • Breaking changes (not a breaking change)

@agostbiro agostbiro requested a review from prestwich as a code owner May 10, 2024 12:40
@agostbiro
Copy link
Contributor Author

Thanks for the quick review @prestwich! I can repro the CI failures locally, I'm looking into it.

DaniPopes
DaniPopes approved these changes May 10, 2024
View reviewed changes
Copy link
Member

@DaniPopes DaniPopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated to this PR, looks like an unintended breaking change in winnow or similar. Thanks!

@DaniPopes DaniPopes merged commit bc25dbb into alloy-rs:main May 10, 2024
21 of 30 checks passed
@agostbiro agostbiro mentioned this pull request May 12, 2024
Closed
@agostbiro agostbiro deleted the agostbiro/eq-for-typed-data branch May 15, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaniPopes DaniPopes DaniPopes approved these changes

@prestwich prestwich prestwich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@agostbiro @prestwich @DaniPopes