Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dyn-abi): derive Eq for TypedData #623

Merged
merged 1 commit into from
May 10, 2024
Merged

feat(dyn-abi): derive Eq for TypedData #623

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/dyn-abi/src/eip712/resolver.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,7 @@ struct DfsContext<'a> {
/// A dependency graph built from the `Eip712Types` object. This is used to
/// safely resolve JSON into a [`crate::DynSolType`] by detecting cycles in the
/// type graph and traversing the dep graph.
#[derive(Clone, Debug, Default)]
#[derive(Clone, Debug, Default, PartialEq, Eq)]
pub struct Resolver {
/// Nodes in the graph
// NOTE: Non-duplication of names must be enforced. See note on impl of Ord
Expand Down
2 changes: 1 addition & 1 deletion crates/dyn-abi/src/eip712/typed_data.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ impl<'de> Deserialize<'de> for Eip712Types {
/// "required": ["types", "primaryType", "domain", "message"]
/// }
/// ```
#[derive(Debug, Clone, Serialize)]
#[derive(Debug, Clone, PartialEq, Eq, Serialize)]
pub struct TypedData {
/// Signing domain metadata. The signing domain is the intended context for
/// the signature (e.g. the dapp, protocol, etc. that it's intended for).
Expand Down
Loading