feat: implement namespaces on sol! side
#693
Merged
+191
−105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
reviewed
Jul 25, 2024
DaniPopes
merged commit 3c59f3a
into
alloy-rs:dani/to-sol-contract-specifiers
29 checks passed
3 tasks
DaniPopes
added a commit
that referenced
this pull request
Aug 12, 2024
* wip * wip * feat: implement namespaces on `sol!` side (#693) * respect namespaces * un-ignore test * clippy * clippy * fix doc * rm debug prints * chore: cleanup * fix: correctly expand derives for namespaced JSON outputs (#704) * fix * newline * chore: clippy * chore: use mem::replace * fix: respect namespaces when resolving overloads * test: add regression test * chore: link the test --------- Co-authored-by: Arsenii Kulikov <klkvrr@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Makes
sol!macro respect namespaces.Solution
current_namespacecontext variable is added toExpCtxtwhich is switched when we enter/exit contract body during AST traversal or expansion.all_items,custom_typesandoverloaded_itemsare wrapped intoNamespacedMapwhich resolves fullSolPaths depending on current namespacecc @DaniPopes please take a look and lmk if I should switch base to master instead
PR Checklist