-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sol-macro): support namespaces #694
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
just tested locally and it seems that derives aren't applied to generated libraries in json abi input causing compilation issues e.g. this would cause sol!(
#[derive(Debug)]
Contract,
r#"[
{
"type": "function",
"name": "f",
"inputs": [
{
"name": "s",
"type": "tuple",
"internalType": "struct Lib.Struct",
"components": [
{
"name": "a",
"type": "uint256",
"internalType": "uint256"
}
]
}
],
"outputs": [],
"stateMutability": "nonpayable"
}
]"#
); |
And would also be a pretty big breaking change |
3 tasks
3 tasks
This is broken now, marking as draft again: sol! {
contract Vm {
struct Wallet {
uint stuff;
}
/// Gets the nonce of an account.
function getNonce(address account) external view returns (uint64 nonce);
/// Get the nonce of a `Wallet`.
function getNonce(Wallet calldata wallet) external returns (uint64 nonce);
}
} |
Updated in 8fe0df0, we didn't apply namespaces when resolving overloads |
klkvr
force-pushed
the
dani/to-sol-contract-specifiers
branch
from
August 8, 2024 04:51
18c2ed4
to
8fe0df0
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #660
Closes #599