Skip to content
This repository has been archived by the owner on Jul 29, 2019. It is now read-only.

Network - Navigation Zoom is broken (4.18) #2613

Closed
Kokozzi opened this issue Jan 22, 2017 · 3 comments
Closed

Network - Navigation Zoom is broken (4.18) #2613

Kokozzi opened this issue Jan 22, 2017 · 3 comments
Milestone
Patch release v4....

Comments

@Kokozzi
Copy link

Kokozzi commented Jan 22, 2017 •
edited
Loading

After #2377 commit to 4.18 Zoom events for Navigation at Network module are broken. Example of it is active at official example page - http://visjs.org/examples/network/other/navigation.html

Uncaught ReferenceError: pointer is not defined - when trying to zoom in or zoom out with help of bottom buttons.
@Tooa Tooa added this to the Patch release v4.18.1 milestone Jan 22, 2017
@Tooa
Copy link
Member

Tooa commented Jan 22, 2017 •
edited
Loading

I can confirm this issue. There is no pointer in the scope of the button events :/

@yoavdamri can you take a look at this?

@yoavdamri
Copy link
Contributor

@Tooa, I saw it, in this case i can pass null (since the pointer is not relevant) or the translation x, y.
what do you think?

CapitanMorgan added a commit to CapitanMorgan/vis that referenced this issue Jan 23, 2017
@CapitanMorgan
fix almende#2613 with if statement, and null for pointer value rather…
794cc2c 
… than referencing it when undefined
yotamberk pushed a commit that referenced this issue Jan 24, 2017
@CapitanMorgan @yotamberk
fix #2613 with if statement, and null for pointer value rather than r… (
bf71d7e 
#2615)

* fix #2613 with if statement, and null for pointer value rather than referencing it when undefined

* removed if statement, since not needed, and updated documentation to note the null pointer property in certain conditions.
@Tooa
Copy link
Member

Tooa commented Jan 25, 2017

Thanks for reporting this issue. Fixed by @CapitanMorgan with #2615

@Tooa Tooa closed this as completed Jan 25, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Patch release v4.18.1
Development

No branches or pull requests
3 participants
@Tooa @yoavdamri @Kokozzi