This repository has been archived by the owner on Jul 29, 2019. It is now read-only.
fix #2613 with if statement, and null for pointer value rather than r… #2615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… than referencing it when undefined
Tooa
suggested changes
Jan 23, 2017
| @@ -160,7 +160,12 @@ class NavigationHandler { | |||
|
|
|||
| this.body.view.scale = scale; | |||
| this.body.view.translation = { x: tx, y: ty }; | |||
| this.body.emitter.emit('zoom', { direction: '+', scale: this.body.view.scale, pointer: pointer }); | |||
| if (typeof(pointer) != 'undefined') { | |||
There was a problem hiding this comment.
Why do we need this conditional expression here? There is no pointer in the scope, so this expression always evaluates to false, right?
| @@ -172,7 +177,11 @@ class NavigationHandler { | |||
|
|
|||
| this.body.view.scale = scale; | |||
| this.body.view.translation = { x: tx, y: ty }; | |||
| this.body.emitter.emit('zoom', { direction: '-', scale: this.body.view.scale, pointer: pointer }); | |||
| if (typeof(pointer) != 'undefined') { | |||
|
Ill remove the if, i just threw it together hastily and thought the previous person who added this pointer reference, actually had a scenario were it might not be null. Ill just pass null, found the spot in the documentation (docs/network/index.html) and added the note about it, is there any other spots that needed updating? |
…note the null pointer property in certain conditions.
Tooa
approved these changes
Jan 24, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with if statement, and passing null for pointer value rather than referencing it when undefined