Skip to content
This repository has been archived by the owner on Jul 29, 2019. It is now read-only.

Unmet peer dependency webpack@1 || 2 || ^2.1.0-beta || ^2.2.0-rc #2685

Closed
BrandonNoad opened this issue Feb 6, 2017 · 12 comments
Closed

Unmet peer dependency webpack@1 || 2 || ^2.1.0-beta || ^2.2.0-rc #2685

BrandonNoad opened this issue Feb 6, 2017 · 12 comments
Assignees
Milestone

Comments

@BrandonNoad
Copy link

BrandonNoad commented Feb 6, 2017

When I run npm install vis, I'm getting the following warning:

└─┬ vis@4.18.1
  └── UNMET PEER DEPENDENCY webpack@1 || 2 || ^2.1.0-beta || ^2.2.0-rc

npm WARN babel-loader@6.2.10 requires a peer of webpack@1 || 2 || ^2.1.0-beta || ^2.2.0-rc but none was installed.
@yotamberk
Copy link
Contributor

@mojoaxel Can you take care of this?

@mojoaxel mojoaxel self-assigned this Feb 7, 2017
@mojoaxel mojoaxel added this to the Minor Release v4.19 milestone Feb 7, 2017
@rretter
Copy link

rretter commented Feb 8, 2017

Just installed node.js, which worked.
Just tried to install vis, which didn't, reporting this same problem.
Not so great a sign when software doesn't even install correctly.
Is installing even tried before a version gets put forth for general use?

@yotamberk
Copy link
Contributor

@BrandonNoad Thanks for reporting.
@rretter It's kind of rude to answer like that... Sometime we miss things... We are currently working on automated tests so we don't have these kinds of misses. In any case, a bit of manners would be appreciated... We do this project for fun - we don;t get paid to do this...

@mojoaxel mojoaxel reopened this Feb 8, 2017
@mojoaxel
Copy link
Member

mojoaxel commented Feb 8, 2017

I'll try to take a look later tonight.
@rretter Yes, oft course we test the lib before releasing. Not sure what went wrong here...

@yotamberk
Copy link
Contributor

Whoops. I didn't mean to close it... sorry

@mojoaxel
Copy link
Member

mojoaxel commented Feb 8, 2017

Looks like this was introduced in #2513 (4.18.0).
Because I had webpack@2 installed globally I did not noticed the problem during testing. Sorry!

@BrandonNoad
Copy link
Author

I was able to install 4.18.0...but not 4.18.1.

@mojoaxel
Copy link
Member

mojoaxel commented Feb 9, 2017

Strange. Should be fixed now. (after 4.18.1)
We should keep a close eye on this topic during the next release.

@krispyp
Copy link

krispyp commented Feb 10, 2017

I'm getting this with 4.18.1. I'm not installing dev dependencies, and then cannot shrinkwrap due to unmet peer dependency.

It seems the problem is that you have babel-loader as a dependency:
https://github.com/almende/vis/blob/master/package.json#L33

I can only see it being used by a gulpfile, so probably this should be a dev dependency.

The problem happens because babel-loader has a peer dep on webpack. So if you only install deps, babel-loader is installed without its peer dep webpack alongside it.

@mojoaxel mojoaxel removed the PRIORITY label Feb 14, 2017
@mojoaxel
Copy link
Member

will be (hopefully) bee fixed in v4.19.0

@mojoaxel
Copy link
Member

💩 This is still an issue with 4.19.0

@mojoaxel mojoaxel reopened this Mar 18, 2017
@mojoaxel mojoaxel modified the milestones: Patch Milestone v4.19.1, Minor Release v4.19 Mar 18, 2017
@mojoaxel
Copy link
Member

Keep it open until merged with master

@mojoaxel mojoaxel reopened this Mar 19, 2017
yotamberk pushed a commit that referenced this issue May 2, 2017
* Add Gitter badge (#2179)

* do not generate source-maps in distribution version

* add 'dist' folder for deployment

* added Badges

* added codeclimate badge

* added @Tooa to the support team

* added badges from isitmaintained.com (#2517)

* do not ignore dist and test folders in master

* generated dist files for v4.18.0

* generated dist files for v4.18.1

* Cheap fix for bug #2795

* Update to PR #2826 to use newline format

* changed to v4.18.1-SNAPSHOT

* chore(docs): general improvements (#2652)

* removed NOTICE file

* updated license date range to include 2017

* chore(docs): updated support team members

* chore: updated dependencies and devDependencies (#2649)

* Fixes instanceof Object statements for objects from other windows and iFrames. (#2631)

* Replaces instanceof Object checks with typeof to prevent cross tab issues.

* Adds missing space.

* chore: removed google-analytics from all examples (#2670)

* chore(docs): Add note that PRs should be submitted against the `develop` branch (#2623)

Related to: #2618
Related to: #2620

* feat(timeline): Change setCustomTimeTitle title parameter to be a string or a function (#2611)

* change setCustomTimeTitle title parameter, Now could be an string or a function
* Fixed indent and spacing

* feat(timeline): refactor tooltip to only use one dom-element (#2662)

* feat(network): Allow for image nodes to have a selected or broken image (#2601)

* feat(tests): run mocha tests in travis ci (#2687)

* Added showX(YZ)Axis options to Graph3d (#2686)

* Added showX(YZ)Axis to Graph3d

* Added show_Axis options to docs and playground example

* Resolved merge conflict

* Added show_Axis options to docs and playground example

* fix(build): use babel version compatible with webpack@1.14 (#2693)

fixes #2685

* feat(docs): use babel preset2015 for custom builds (#2678)

* add link to a mentioned example (#2709)

* chore(lint): added support for eslint (#2695)

* Trivial typo fix in how_to_help doc. (#2714)

* fix(timeline): #2598 Flickering onUpdateTimeTooltip (#2702)

* Fix redraw order
* Fix error when option is not defined
* Allow template labels
* Add .travis.yml file
* Add experiment travis code
* Fix react example
* Add animation to onUpdateTooltip

* fix(timeline): #778 Tooltip does not work with background items in timeline (#2703)

* Fix redraw order
* Fix error when option is not defined
* Allow template labels
* Add .travis.yml file
* Add experiment travis code
* Fix react example
* Make items z-index default to 1

* Add initial tests for Timeline PointItem (#2716)

* fix(timeline): #2679 TypeError: Cannot read property 'hasOwnProperty' of null (#2735)

* Fix redraw order
* Fix error when option is not defined
* Allow template labels
* Add .travis.yml file
* Add experiment travis code
* Fix react example
* Fix bug in item editable

* feat(timeline): #2647 Dynamic rolling mode option (#2705)

* Fix redraw order
* Fix error when option is not defined
* Allow template labels
* Add .travis.yml file
* Add experiment travis code
* Fix react example
* Add toggleRollingMode option
* Update docs with toggleRollingMode option

* fixes timestep next issue (#2732)

* feat(timeline): added new locales for french and espanol (#2723)

* Fix eslint problem on Travis. (#2744)

* fix: Range.js "event" is undeclared (#2749)

* fix(timeline): #2720 Problems with option editable (#2743)

Clean up and centralise edit status for Timeline Items.

* feat(network): Improve the performance of the network layout engine (#2729)

* Improve the performance of the network layout engine

Short-cut the execution of a number of methods in LayoutEngine to make them
handle highly-connected graphs better.

* Demonstrations of layouts of large networks

* Added support to supply an end to bar charts to have them scale (#2760)

* Added support to supply an X2 to bar charts to have them scale

* Fixed graph2d stacking issue.  It no longer takes into account hidden items

* Changed x2 to end per recommendation and added this to the docs

* Initial tests for timeline ItemSet. (#2750)

Somewhat more complicated setup, associated with the need for a real window.

* [Timeline] Modify redraw logic to treat scroll as needing restack. (#2774)

This addresses #1982 and #1417.

It possibly reduces performance, but correctness seems better.

* fix(timeline): #2672 Item events original event (#2704)

* Fix redraw order

* Fix error when option is not defined

* Allow template labels

* Add .travis.yml file

* Add experiment travis code

* Fix react example

* Fix events returned from mouse events

* Fix example

* Rename censor to stringifyObject in example

* [timeline] Update examples to use ISOString format. (#2791)

Resolves #2790

* [timeline] Update serialization example to use ISOString dates. (#2789)

Resolves #2696

* added github templates for issues and pull-requests (#2787)

fixes #2418

* feat(timeline): Add item data as argument to the template function (#2799)

* Fix regression introduced in #2743. (#2796)

* Fix for issue #2536 (#2803)

* Fix for issue #2536

* Adjusted documentation for fix.

* Adjustments due to review

* Grrrrr whitespace

* Fixed Travis issue

* Cheap fix for bug #2795

* Update to PR #2826 to use newline format

* Update to gitignore to reflect changes on remote

* clean dist folder

* Local gitignore update

* Just a first example file for the week scale feature

* Allowing sourcemap creation

* Initial (non-functional) commit to ensure we insert code at the right places (check TODOs)

* Functional, not bug-free version which works with locale aware week numbers.

* Locale-aware implementation and simplified major labels to a full year

* Trying to make the major labels show the correct start date

* Working implementation of week numbers using localization.

* removing development leftovers

* Updated package.json

* Reintagrate package.json from accidental deletion

* Updates for package.json

* Fixing package.json

* Integrate the week numbers feature in the documentation.

* Reverting local changes to .gitignore

* Reverting local changes

* Extending examples to cover the case when 1st day of week and 1st day of month align; Fixing display bug so that week numbers are not repeated in minorLabels

* Putting the examples into a loop
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants